Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

future3: Jukebox.Dockerfile - Reorder 'USER' command #2199

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

votti
Copy link

@votti votti commented Jan 2, 2024

This makes sure the 'venv' is created only after switching to the $USER.
This prevents permission errors if building the container in an environment where the user is not pi.

Closes issue #2198

This makes sure the 'venv' is initalized using the correct user, preventing permission errors

Closes issue MiczFlor#2198
@votti votti force-pushed the future3/fix/issue-#2198 branch from 720a7c6 to a7bc5e2 Compare January 2, 2024 16:38
@votti votti changed the title Reorder 'USER' command future3: Jukebox.Dockerfile - Reorder 'USER' command Jan 2, 2024
@pabera
Copy link
Collaborator

pabera commented Jan 2, 2024

Looks good from my side. Ready to merge?

@pabera pabera self-requested a review January 2, 2024 20:34
@s-martin
Copy link
Collaborator

s-martin commented Jan 2, 2024

Yeah. Was already discussed in #2167

@s-martin s-martin merged commit c713610 into MiczFlor:future3/develop Jan 2, 2024
3 checks passed
@votti votti deleted the future3/fix/issue-#2198 branch January 3, 2024 08:12
AlvinSchiller pushed a commit to AlvinSchiller/RPi-Jukebox-RFID that referenced this pull request Jan 9, 2024
This makes sure the 'venv' is initalized using the correct user, preventing permission errors

Closes issue MiczFlor#2198

Co-authored-by: pre-commit fix Vito Zanotelli <[email protected]>
@pabera pabera added this to the v3.5 milestone Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants