Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better logging functions for Installation script #2152

Merged
merged 10 commits into from
Dec 11, 2023
Merged

Better logging functions for Installation script #2152

merged 10 commits into from
Dec 11, 2023

Conversation

pabera
Copy link
Collaborator

@pabera pabera commented Dec 11, 2023 •
edited
Loading

We had used repetitive solutions for logging in the installation script. I have change it to be more readable and maintainable in the long run.

print_lc    "This message will be logged to both console and logfile"
print_c     "This message will only be logged to the console"
log         "This message will only be logged to the logfile"
run_and_log "Run a command and log its output to logfile"
clear_c     "Clears the console screen"

Nothing has been changed except for the new functions.

@pabera pabera added the future3 Relates to future3 development label Dec 11, 2023
@pabera pabera self-assigned this Dec 11, 2023
AlvinSchiller
AlvinSchiller requested changes Dec 11, 2023
View reviewed changes
installation/README.md Outdated Show resolved Hide resolved
installation/README.md Show resolved Hide resolved
installation/README.md Outdated Show resolved Hide resolved
installation/install-jukebox.sh Outdated Show resolved Hide resolved
installation/routines/customize_options.sh Outdated Show resolved Hide resolved
installation/routines/customize_options.sh Outdated Show resolved Hide resolved
installation/routines/customize_options.sh Show resolved Hide resolved
installation/routines/setup_git.sh Outdated Show resolved Hide resolved
installation/routines/setup_git.sh Outdated Show resolved Hide resolved
installation/routines/setup_rfid_reader.sh Outdated Show resolved Hide resolved
s-martin
s-martin reviewed Dec 11, 2023
View reviewed changes
installation/README.md Outdated Show resolved Hide resolved
AlvinSchiller
AlvinSchiller reviewed Dec 11, 2023
View reviewed changes
installation/install-jukebox.sh Outdated Show resolved Hide resolved
installation/README.md Outdated Show resolved Hide resolved
@pabera pabera merged commit 50e8446 into MiczFlor:future3/develop Dec 11, 2023
14 checks passed
@pabera pabera deleted the future3/better-logging branch December 11, 2023 16:03
AlvinSchiller pushed a commit to AlvinSchiller/RPi-Jukebox-RFID that referenced this pull request Jan 9, 2024
@pabera @AlvinSchiller
Better logging functions for Installation script (MiczFlor#2152)
d5fe7e2 
* Introduce proper logging functions

* Fix a few minor things

* Introduce clear_c

* A few minor bugfixes

* Introduce run_and_log() function

* Rename function to run_and_print_lc

* Log IP address if static is chosen

* Revert "Log IP address if static is chosen"

This reverts commit 8852d97.

* Update commit for run_and_print_lc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlvinSchiller AlvinSchiller AlvinSchiller approved these changes

@s-martin s-martin s-martin approved these changes

Assignees

@pabera pabera

Labels
future3 Relates to future3 development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pabera @s-martin @AlvinSchiller