-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v3.4.0 #2137
Merged
Merged
Release v3.4.0 #2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pabera
commented
Dec 7, 2023
•
edited
Loading
edited
- CI Workflow
- Allow custom username
- Bump libzmq to 4.3.5
- Fixes Webapp not working in Firefox
- Introduce better functions for Installation logging
- Minor fixes
* add ci workflow * add check for user home * changes for docker tests * added verify functions * exit on failed update * add check for samba setup * add check for mpd setup * add check for jukebox core setup * add check for git setup * add check for kiosk mode setup * add check for optimize boot setup * add check for webapp setup * add check for autohotspot setup * make rfid reader setup an optional step * Add Option for No Rfid Reader * moved setup checks to individual scripts * fix missing iw package * refactored get_reader_descriptions into function. be more consistent by using same var for display and index access * moved function to specific routine script * make sure verify parameters are all set. fix functionnames * added fix for not available interface in CI runs * check supported os type first * moved exit_on_error function top level * moved logging setup to function and added usage * moved load sources to function * change function name and var usage * updated log output for better logfile readability * harmonize log output * refactored disable onboard audio. only execute if flag is true. inlined function * add restart nginx.service again. use HOME_PATH * fix and check adding samba user * fix logging mpd setup routine * fix Disable boot logs error on existing file * added timer to log frame * add core package installation from file used also for ci optimization * Dont let remove packages fail install. ignore for ci * Update test scripts use robust path determination move noninteractive to dockerfile * fix clear in mpd option * fix bug in rfid configure * fix error on uninitialized rfid_reader settings * add checks for static ip config * Added test for webapp download in prod. Update test descriptions. * renamend workflow files to not interfere with develop branch * Update install links
* Add badges to future3 * Add python action badge
* removed hardcoded references to user "pi" * removed check userNotPi * change testuser in workflow and container * updated docs * updated comments and docs * updated comments and docs * remove extra home_path check * changes testuser name and group
fix folder handling ZMQ_TMP_DIR. remove libsodium (use internal encryption lib tweetnacl). add cpu_count. add --disable-Werror. add sudo to make install. update log messaages.
Fix libzmq local build
Future3/bump-libzmq
s-martin
approved these changes
Dec 8, 2023
* [Bugfix][Dockerfile] Mount jukebox code as volume to support restart without build * Fix typo * [get_song_by_url] Search for relative paths in MPD database only
* Add running pytest * Trigger running the action * Remove Python 3.7 to check * support only bullseye and bookworm python versions * Add coverage check with coveralls * use coverage for ci * add coverage package * consider review comments
pabera
commented
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title of this commit sounds very promising compared to the actual file change 😄
harmonize paths updated doc for coreapps and references fix execution docs for run_jukebox.py
* Introduce proper logging functions * Fix a few minor things * Introduce clear_c * A few minor bugfixes * Introduce run_and_log() function * Rename function to run_and_print_lc * Log IP address if static is chosen * Revert "Log IP address if static is chosen" This reverts commit 8852d97. * Update commit for run_and_print_lc
* some improvements in the docs * improve docs * Revert change * Fix whitespace * Fix deactivate command vor venv --------- Co-authored-by: pabera <[email protected]>
AlvinSchiller
approved these changes
Dec 11, 2023
s-martin
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.