Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix outdated reg names in deployment samples #189

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: fix outdated reg names in deployment samples #189

wants to merge 1 commit into from

Commits on May 11, 2023

  1. fix: fix outdated reg names in deployment samples 

    Currently deployment samples `WV2DeploymentWiXCustomActionSample` and `WV2DeploymentWiXBurnBundleSample` use the reg name `EBWebView` for registry searching, but this entry has already disappeared in recent versions of WVRT (also disappeared in Edge Stable).

![](https://github.com/MicrosoftEdge/WebView2Samples/assets/20179549/54090887-3b70-4e90-90fb-1f061e26963e)

![](https://github.com/MicrosoftEdge/WebView2Samples/assets/20179549/d3937bb9-b278-4db0-8c11-3dee80feae97)

Changed them to `pv`, consistent with `WV2DeploymentVSInstallerSample`.

Also I noticed that these three registry searches were introduced in the same PR (MicrosoftEdge#56). Are there any special considerations for the inconsistency here?

Related commit:

MicrosoftEdge@8402697
    @ilharp
    ilharp committed May 11, 2023
    Configuration menu
    Copy the full SHA
    92b7da6 View commit details
    Browse the repository at this point in the history