Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move samples repos Readme content into regular Docs #2069

Merged
merged 35 commits into from
Sep 16, 2022

Conversation

mikehoffms
Copy link
Contributor

@mikehoffms mikehoffms commented Jul 19, 2022

@mikehoffms mikehoffms added the cat: webview2 WebView-related content. label Jul 20, 2022
@MicrosoftDocs MicrosoftDocs deleted a comment from opbld32 Jul 21, 2022
@MicrosoftDocs MicrosoftDocs deleted a comment from opbld32 Jul 21, 2022
@MicrosoftDocs MicrosoftDocs deleted a comment from opbld33 Jul 21, 2022
@mikehoffms mikehoffms marked this pull request as ready for review July 21, 2022 01:44
@MicrosoftDocs MicrosoftDocs deleted a comment from opbld32 Jul 21, 2022
@MicrosoftDocs MicrosoftDocs deleted a comment from opbld33 Jul 21, 2022
@opbld33

This comment was marked as outdated.

@mikehoffms mikehoffms marked this pull request as draft July 21, 2022 20:06
@mikehoffms mikehoffms changed the title Move samples repos Readme content into regular Docs Expand Readme steps to be explicit end-to-end Jul 21, 2022
@mikehoffms mikehoffms changed the title Expand Readme steps to be explicit end-to-end Move samples repos Readme content into regular Docs Jul 23, 2022
@mikehoffms mikehoffms marked this pull request as ready for review July 23, 2022 00:19
@opbld31

This comment was marked as outdated.

@opbld31

This comment was marked as outdated.

@opbld31

This comment was marked as outdated.

@opbld30

This comment was marked as outdated.

Copy link
Contributor

@captainbrosset captainbrosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me.

microsoft-edge/webview2/samples/webview2browser.md Outdated Show resolved Hide resolved
Copy link
Contributor

@JasonAndrewWriter JasonAndrewWriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was very clean. I hardly found anything.

@opbld31

This comment was marked as outdated.

@opbld33

This comment was marked as outdated.

@opbld31

This comment was marked as outdated.

@opbld31

This comment was marked as outdated.

@opbld30

This comment was marked as outdated.

@mikeshhoffman
Copy link
Contributor

@nishitha-burman - please review and possibly approve this PR. @Reezaali @captainbrosset fyi/test msg

  • mikeshhoffman (pers.)

@opbld30

This comment was marked as outdated.

@opbld33
Copy link

opbld33 commented Sep 15, 2022

Docs Build status updates of commit c1b2aac:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/media/windows-keyboard-logo.png ✅Succeeded View
microsoft-edge/toc.yml ✅Succeeded View
microsoft-edge/webview2/code-samples-links.md ✅Succeeded View
microsoft-edge/webview2/concepts/basic-authentication.md ✅Succeeded View
microsoft-edge/webview2/concepts/distribution.md ✅Succeeded View
microsoft-edge/webview2/concepts/navigation-events.md ✅Succeeded View
microsoft-edge/webview2/concepts/process-model.md ✅Succeeded View
microsoft-edge/webview2/concepts/threading-model.md ✅Succeeded View
microsoft-edge/webview2/get-started/get-started.md ✅Succeeded View
microsoft-edge/webview2/get-started/media/vs2022-create-a-new-project.png ✅Succeeded n/a (file deleted)
microsoft-edge/webview2/get-started/media/wpf-getting-started-mng-nuget.png ✅Succeeded n/a (file deleted)
microsoft-edge/webview2/get-started/win32.md ✅Succeeded View
microsoft-edge/webview2/get-started/winforms.md ✅Succeeded View
microsoft-edge/webview2/get-started/winui.md ✅Succeeded View
microsoft-edge/webview2/get-started/winui2.md ✅Succeeded View
microsoft-edge/webview2/get-started/wpf.md ✅Succeeded View
microsoft-edge/webview2/how-to/chromium-devtools-protocol.md ✅Succeeded View
microsoft-edge/webview2/how-to/hostobject.md ✅Succeeded View
microsoft-edge/webview2/how-to/machine-setup.md ✅Succeeded View
microsoft-edge/webview2/how-to/winrt-from-js.md ✅Succeeded View
microsoft-edge/webview2/index.md ✅Succeeded View
microsoft-edge/webview2/samples/deployment-samples.md ✅Succeeded View
microsoft-edge/webview2/samples/media/unsupported-review-project-dialog.png ✅Succeeded View
microsoft-edge/webview2/samples/media/webview2apisample-app-window.png ✅Succeeded n/a (file deleted)
microsoft-edge/webview2/samples/media/webview2apisample-in-solution-explorer.png ✅Succeeded n/a (file deleted)

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@captainbrosset
Copy link
Contributor

As discussed with Michael offline, Nishitha has already approved this somewhere else. So I'll go ahead and merge this.

@captainbrosset captainbrosset merged commit e845ee6 into main Sep 16, 2022
@captainbrosset captainbrosset deleted the user/v-mhoffman/readmes-content branch September 16, 2022 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: webview2 WebView-related content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants