Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Tax calculation service #1708

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

witmax
Copy link

@witmax witmax commented Nov 11, 2024

The tax calculation service is merged into Dynamics 365 Finance. Thus need to update the related documents

Pull request guidance

Thank you for submitting your contribution to our support content! Our team works closely with subject matter experts in CSS and PMs in the product group to review all content requests to ensure technical accuracy and the best customer experience. This process can sometimes take one or more days, so we greatly appreciate your patience.

We also need your help in order to process your request as soon as possible:

  • We won't act on your pull request (PR) until you type "#sign-off" in a new comment in your pull request (PR) to indicate that your changes are complete.

  • After you sign off in your PR, the article will be tech reviewed by the PM or SME if it has more than minor changes. Once the article is approved, it will undergo a final editing pass before being merged.

Copy link

@witmax : Thanks for your contribution! The author(s) have been notified to review your proposed change. @Hangwan, @wangchen

Copy link
Contributor

Learn Build status updates of commit e931928:

✅ Validation status: passed

File Status Preview URL Details
support/dynamics-365/finance/tax/tcs-troubleshooting-enable-debug-mode.md ✅Succeeded
support/dynamics-365/finance/tax/tcs-troubleshooting-failed-access-tax-service.md ✅Succeeded n/a (file deleted or renamed)
support/dynamics-365/finance/tax/tcs-troubleshooting-no-matching-result.md ✅Succeeded
support/dynamics-365/finance/tax/tcs-troubleshooting-tax-code-cannot-be-determined.md ✅Succeeded
support/dynamics-365/finance/tax/tcs-troubleshooting-tax-feature-list-empty-tax-calculation-parameter.md ✅Succeeded
support/dynamics-365/finance/toc.yml ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

PRMerger Results

Issue Description
Deleted File(s) This PR deletes Markdown or YAML files owned by another author, or json file(s). The pull request must contain a comment from the pull request author confirming that all the file deletions are intentional before the pull request can be merged.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
File Change Percent This PR contains file(s) with more than 30% file change.

Copy link
Contributor

Learn Build status updates of commit 8504a34:

✅ Validation status: passed

File Status Preview URL Details
support/dynamics-365/finance/tax/tcs-troubleshooting-enable-debug-mode.md ✅Succeeded
support/dynamics-365/finance/tax/tcs-troubleshooting-failed-access-tax-service.md ✅Succeeded n/a (file deleted or renamed)
support/dynamics-365/finance/tax/tcs-troubleshooting-no-matching-result.md ✅Succeeded
support/dynamics-365/finance/tax/tcs-troubleshooting-tax-code-cannot-be-determined.md ✅Succeeded
support/dynamics-365/finance/tax/tcs-troubleshooting-tax-feature-list-empty-tax-calculation-parameter.md ✅Succeeded
support/dynamics-365/finance/toc.yml ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

PRMerger Results

Issue Description
Deleted File(s) This PR deletes Markdown or YAML files owned by another author, or json file(s). The pull request must contain a comment from the pull request author confirming that all the file deletions are intentional before the pull request can be merged.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
File Change Percent This PR contains file(s) with more than 30% file change.

@lucciz01
Copy link
Collaborator

lucciz01 commented Nov 12, 2024

Hi @witmax and @aartig13, I created PR#7658 in private repo for internal discussion and review.

Copy link
Contributor

Learn Build status updates of commit e6cea01:

⚠️ Validation status: warnings

File Status Preview URL Details
support/dynamics-365/finance/tax/cannot-set-dataverse-virtual-table-visibility.md ⚠️Warning Details
support/dynamics-365/finance/tax/tcs-troubleshooting-no-matching-result.md ⚠️Warning Details
support/dynamics-365/finance/tax/tcs-troubleshooting-tax-code-cannot-be-determined.md ⚠️Warning Details
support/dynamics-365/finance/tax/tcs-troubleshooting-tax-feature-list-empty-tax-calculation-parameter.md ⚠️Warning Details
support/dynamics-365/finance/tax/tcs-troubleshooting-enable-debug-mode.md ✅Succeeded
support/dynamics-365/finance/tax/tcs-troubleshooting-failed-access-tax-service.md ✅Succeeded n/a (file deleted or renamed)
support/dynamics-365/finance/toc.yml ✅Succeeded

support/dynamics-365/finance/tax/cannot-set-dataverse-virtual-table-visibility.md

  • Line 1, Column 1: [Warning: title-missing - See documentation] Missing required attribute: 'title'. Add a title string to show in search engine results.
  • Line 14, Column 21: [Warning: yaml-header-syntax-error - See documentation] While scanning a plain scalar value, found invalid mapping.
  • Line 14, Column 21: [Warning: yaml-header-syntax-error - See documentation] While scanning a plain scalar value, found invalid mapping.
  • Line 1, Column 1: [Suggestion: ms-date-missing - See documentation] Missing required attribute: 'ms.date'.
  • Line 1, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

support/dynamics-365/finance/tax/tcs-troubleshooting-no-matching-result.md

  • Line 1, Column 1: [Warning: title-missing - See documentation] Missing required attribute: 'title'. Add a title string to show in search engine results.
  • Line 16, Column 21: [Warning: yaml-header-syntax-error - See documentation] While scanning a plain scalar value, found invalid mapping.
  • Line 1, Column 1: [Suggestion: ms-date-missing - See documentation] Missing required attribute: 'ms.date'.
  • Line 1, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

support/dynamics-365/finance/tax/tcs-troubleshooting-tax-code-cannot-be-determined.md

  • Line 1, Column 1: [Warning: title-missing - See documentation] Missing required attribute: 'title'. Add a title string to show in search engine results.
  • Line 16, Column 21: [Warning: yaml-header-syntax-error - See documentation] While scanning a plain scalar value, found invalid mapping.
  • Line 1, Column 1: [Suggestion: ms-date-missing - See documentation] Missing required attribute: 'ms.date'.
  • Line 1, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

support/dynamics-365/finance/tax/tcs-troubleshooting-tax-feature-list-empty-tax-calculation-parameter.md

  • Line 1, Column 1: [Warning: title-missing - See documentation] Missing required attribute: 'title'. Add a title string to show in search engine results.
  • Line 16, Column 21: [Warning: yaml-header-syntax-error - See documentation] While scanning a plain scalar value, found invalid mapping.
  • Line 1, Column 1: [Suggestion: ms-date-missing - See documentation] Missing required attribute: 'ms.date'.
  • Line 1, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@lucciz01
Copy link
Collaborator

lucciz01 commented Nov 14, 2024

The article -https://learn.microsoft.com/en-us/troubleshoot/dynamics-365/finance/tax/tcs-troubleshooting-failed-access-tax-service.md has been removed and redirected to the Finance welcome page. Other articles will be republished via the private repo PR-7658 once the SAP is ready. And this PR will be closed when the PR#7658 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants