Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReadyForReview: RSWW-81 Checking transport availability - saga #25

Merged
merged 14 commits into from
May 19, 2024
Merged

ReadyForReview: RSWW-81 Checking transport availability - saga #25

merged 14 commits into from
May 19, 2024

Conversation

Danzigerrr
Copy link
Member

No description provided.

@Danzigerrr Danzigerrr self-assigned this May 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 16, 2024 •
edited
Loading

Test Results

8 tests  +7   8 ✅ +7   26s ⏱️ +13s
4 suites +3   0 💤 ±0 
4 files   +3   0 ❌ ±0 

Results for commit e8303d7. ± Comparison against base commit a514684.

This pull request removes 1 and adds 8 tests. Note that renamed tests count towards both. 
org.microarchitecturovisco.hotelservice.HotelServiceApplicationTests ‑ contextLoads

org.microarchitecturovisco.transport.TransportApplicationTests ‑ contextLoads
org.microarchitecturovisco.transport.services.TransportsQueryServiceAvailableTransportsTest ‑ testGetAvailableTransports_returnsCorrectDto
org.microarchitecturovisco.transport.services.TransportsQueryServiceAvailableTransportsTest ‑ testGetAvailableTransports_returnsEmptyList
org.microarchitecturovisco.transport.services.TransportsQueryServiceGetTransportsBetweenLocationTest ‑ testGetTransportsBetweenLocations_successful
org.microarchitecturovisco.transport.services.TransportsQueryServiceGetTransportsBySearchQueryTest ‑ testGetTransportsBySearchQuery_DateRange
org.microarchitecturovisco.transport.services.TransportsQueryServiceGetTransportsBySearchQueryTest ‑ testGetTransportsBySearchQuery_LocationIds
org.microarchitecturovisco.transport.services.TransportsQueryServiceGetTransportsBySearchQueryTest ‑ testGetTransportsBySearchQuery_People
org.microarchitecturovisco.transport.services.TransportsQueryServiceGetTransportsBySearchQueryTest ‑ testGetTransportsBySearchQuery_UUID_correct

♻️ This comment has been updated with latest results.

@Danzigerrr Danzigerrr changed the title WIP RSWW-81 Booking transport communication set up created ReadyForReview: RSWW-81 Booking transport communication set up created May 16, 2024
@Danzigerrr Danzigerrr requested a review from CzajaLukasz May 16, 2024 17:47
@Danzigerrr Danzigerrr changed the title ReadyForReview: RSWW-81 Booking transport communication set up created ReadyForReview: RSWW-81 Checking transport availability - saga May 16, 2024
@Danzigerrr Danzigerrr force-pushed the RSWW-81-Book-transports-saga branch from 013225e to 772690f Compare May 16, 2024 20:23
@Danzigerrr Danzigerrr requested a review from Mixss May 17, 2024 11:37
@Danzigerrr Danzigerrr changed the title ReadyForReview: RSWW-81 Checking transport availability - saga ReadyForReview: RSWW-80 Checking transport availability - saga May 17, 2024
@Danzigerrr Danzigerrr changed the title ReadyForReview: RSWW-80 Checking transport availability - saga ReadyForReview: RSWW-81 Checking transport availability - saga May 17, 2024
@Danzigerrr
Copy link
Member Author

Danzigerrr commented May 17, 2024 •
edited
Loading

Ostatnie dwa commity powinny iść na inny branch (powinny być na RSWW-79, a nie na RSWW-81).
Zrobię merga z RSWW-81 do RSWW-79a potem gdy RSWW-81 wejdzie na dev to zrobię merga z dev do RSWW-79

@Danzigerrr Danzigerrr requested a review from Mixss May 18, 2024 11:23
Mixss
Mixss reviewed May 18, 2024
View reviewed changes
Copy link
Contributor

@Mixss Mixss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/Microarchitecturovisco/travel-api/pull/25/files#r1605819773
i konflikty @Danzigerrr

@Danzigerrr Danzigerrr requested a review from Mixss May 19, 2024 16:32
@Danzigerrr Danzigerrr merged commit 1962950 into dev May 19, 2024
3 checks passed
@Danzigerrr Danzigerrr deleted the RSWW-81-Book-transports-saga branch May 19, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CzajaLukasz CzajaLukasz Awaiting requested review from CzajaLukasz

@Mixss Mixss Awaiting requested review from Mixss

Assignees

@Danzigerrr Danzigerrr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Danzigerrr @Mixss