Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSWW-55 test: TransportsServiceTest: add date and locationIDs tests for get transports by search query #11

Merged
merged 3 commits into from
May 10, 2024

Conversation

pcichowski
Copy link
Contributor

No description provided.

…or get transports by search query

Signed-off-by: Paweł Cichowski <[email protected]>
Copy link

github-actions bot commented May 10, 2024

Test Results

7 tests  +3   7 ✅ +3   13s ⏱️ -1s
2 suites ±0   0 💤 ±0 
2 files   ±0   0 ❌ ±0 

Results for commit 233e708. ± Comparison against base commit 3f03dce.

♻️ This comment has been updated with latest results.

…e can fit into a mode of transport

Signed-off-by: Paweł Cichowski <[email protected]>
@pcichowski pcichowski requested a review from Mixss May 10, 2024 05:47
@@ -70,8 +70,12 @@ public GetTransportsBySearchQueryResponseDto getTransportsBySearchQuery(GetTrans
List<Transport> filteredTransports = new ArrayList<>();

List<Integer> mergedDepartureLocationIds = new ArrayList<>();
mergedDepartureLocationIds.addAll(requestDto.getDepartureLocationIdsByBus());
mergedDepartureLocationIds.addAll(requestDto.getDepartureLocationIdsByPlane());
if (requestDto.getDepartureLocationIdsByPlane() != null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tu odwrotną logiką zapisane jest to, że po prostu jak są idiki w requeście to brać je pod uwagę rozumiem

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tak, ale w sytuacji kiedy lista idków jest null nie można jej zmergować

@pcichowski pcichowski merged commit 91626f1 into dev May 10, 2024
2 checks passed
@pcichowski pcichowski deleted the RSWW-55-get-transports-by-search-query-extend-tests branch May 10, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants