Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New schema generation pipeline #304

Closed

Conversation

Fyzu
Copy link

@Fyzu Fyzu commented Apr 7, 2019

Related to #183 and #110

  • MetadataStorage store all small parts of metadata from decorators (like now)
  • MetadataBuilder takes resolvers and types class constructors to build the extended, full metadata not modifying MetadataStorage, working like a "pure" function doing it on demand attaching all loose metadata to the base metadata definition handling all extending, implementing and overwrtiting cases.

@Fyzu
Copy link
Author

Fyzu commented Apr 7, 2019

@19majkel94 Can you tell me what else you need to do?

@MichalLytek MichalLytek added Community 👨‍👧 Something initiated by a community Enhancement 🆕 New feature or request Wontfix ❌ This will not be worked on labels Apr 7, 2019
@MichalLytek
Copy link
Owner

MichalLytek commented Apr 7, 2019

@Fyzu
I really appreciate your work 💪

However it's a very complicated task, that's why there's no "help wanted" or "good first issue" label and it's assigned to me.

image

TBH, I am actually rewriting everything from scratch on my next branch, while making simple fixes and features on master.

So sorry, but I can't merge your changes nor cooperate on this PR for now.
However you can continue your work and use your fork until the proper fix will come 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community 👨‍👧 Something initiated by a community Enhancement 🆕 New feature or request Wontfix ❌ This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants