feat(Egghead): Add support for Egghead #115
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Added support for egghead videos/lessons
Why: Fixes #93
How: Added transformer that adds
/embed
to the end of the urlChecklist:
I'm still having issues with the last test on
Plugin can transform egghead links
not entire sure why this one is failing even thought theGet correct egghead iframe
is working. Will need to dig into this deeper to try and figure out why its happening.In regards to the transformer, should we add the title to the iframe? Should we add a
Video hosted on <a href={lessonLink}>egghead.io</a>
message under the video as well?