Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Started writing infrastructure for modes #14

Merged
merged 2 commits into from
Feb 2, 2020
Merged

Started writing infrastructure for modes #14

merged 2 commits into from
Feb 2, 2020

Conversation

Michael-F-Bryan
Copy link
Owner

This is the infrastructure part of #9.

(see Michael-F-Bryan/adventures.michaelfbryan.com#11 for the logic)

@Michael-F-Bryan
Copy link
Owner Author

@DerLando, would you be able to have a quick look over this and let me know what you think?

@DerLando
Copy link
Contributor

DerLando commented Feb 1, 2020

I had a quick look over this and like the idea!

From my understanding it will be possible to compose a Mode from multiple structs which implement State?
That seems close to the spirit of the crate of composition over inheritance.

I don't see any technical pitfalls for now but I'm also not too experienced in rust.

@Michael-F-Bryan Michael-F-Bryan marked this pull request as ready for review February 2, 2020 07:15
@Michael-F-Bryan Michael-F-Bryan merged commit 4228e2b into master Feb 2, 2020
@Michael-F-Bryan Michael-F-Bryan deleted the modes branch February 2, 2020 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants