Fixing memory leak when using nameserver discovery and NetworkAddress…

…Changed events (#68) Removing usage of NetworkChange.NetworkAddressChanged usage to refresh discovered name-servers.
MichaCo · Mar 31, 2020 · 3a1488c · 3a1488c
1 parent db2d7cf
commit 3a1488c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 20 deletions.
diff --git a/src/DnsClient/DnsClient.csproj b/src/DnsClient/DnsClient.csproj
@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <VersionPrefix>1.3.0</VersionPrefix>
+    <VersionPrefix>1.3.1</VersionPrefix>
     <VersionSuffix Condition="'$(VersionSuffix)'!='' AND '$(BuildNumber)' != ''">$(VersionSuffix)-$(BuildNumber)</VersionSuffix>
 
     <TargetFrameworks>netstandard1.3;netstandard2.0;netstandard2.1;net45;net471</TargetFrameworks>

diff --git a/src/DnsClient/LookupClient.cs b/src/DnsClient/LookupClient.cs
@@ -377,15 +377,6 @@ internal LookupClient(LookupClientOptions options, DnsMessageHandler udpHandler
             {
                 _resolvedNameServers = NameServer.ResolveNameServers(skipIPv6SiteLocal: true, fallbackToGooglePublicDns: false);
                 servers = servers.Concat(_resolvedNameServers).ToArray();
-
-                try
-                {
-                    NetworkChange.NetworkAddressChanged += CheckResolvedNameserversCallback;
-                }
-                catch
-                {
-                    // Just in case
-                }
 
                 // This will periodically get triggered on Query calls and
                 // will perform the same check as on NetworkAddressChanged.
@@ -408,16 +399,6 @@ internal LookupClient(LookupClientOptions options, DnsMessageHandler udpHandler
             Cache = new ResponseCache(true, Settings.MinimumCacheTimeout, Settings.MaximumCacheTimeout);
         }
 
-        private void CheckResolvedNameserversCallback(object sender, EventArgs args)
-        {
-            if (_logger.IsEnabled(LogLevel.Information))
-            {
-                _logger.LogInformation("Network change detected, trying to resolve name servers...");
-            }
-
-            CheckResolvedNameservers();
-        }
-
         private void CheckResolvedNameservers()
         {
             try