-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 0.6.4: Hot-Fixes #98
Conversation
…pography tutorial
…in Asteroids sample" (due to missing ARM support for Mac) This reverts commit b343e3a.
…rd-party to latest versions
…let tests run normally
…add indexed component getter to Point
@@ -229,6 +311,13 @@ | |||
template<typename M> | |||
std::enable_if_t<std::is_arithmetic_v<M>, PointType&> operator/=(const Point<M, size>& divisor) noexcept | |||
{ | |||
#if defined(__APPLE__) && defined(__aarch64__) | |||
// FIXME: workaround for HLSL++ issue (https://github.com/redorav/hlslpp/issues/60) |
Check notice
Code scanning / CodeQL
FIXME comment
@@ -199,6 +273,13 @@ | |||
template<typename M> | |||
std::enable_if_t<std::is_arithmetic_v<M>, PointType&> operator/=(M divisor) noexcept | |||
{ | |||
#if defined(__APPLE__) && defined(__aarch64__) | |||
// FIXME: workaround for HLSL++ issue (https://github.com/redorav/hlslpp/issues/60) |
Check notice
Code scanning / CodeQL
FIXME comment
@@ -170,6 +236,13 @@ | |||
template<typename M> | |||
std::enable_if_t<std::is_arithmetic_v<M>, PointType> operator/(const Point<M, size>& divisor) const noexcept | |||
{ | |||
#if defined(__APPLE__) && defined(__aarch64__) | |||
// FIXME: workaround for HLSL++ issue (https://github.com/redorav/hlslpp/issues/60) |
Check notice
Code scanning / CodeQL
FIXME comment
@@ -140,6 +198,13 @@ | |||
template<typename M> | |||
std::enable_if_t<std::is_arithmetic_v<M>, PointType> operator/(M divisor) const noexcept | |||
{ | |||
#if defined(__APPLE__) && defined(__aarch64__) | |||
// FIXME: workaround for HLSL++ issue (https://github.com/redorav/hlslpp/issues/60) |
Check notice
Code scanning / CodeQL
FIXME comment
[[nodiscard]] bool operator==(const PointType& other) const noexcept | ||
{ | ||
#if defined(__APPLE__) && defined(__x86_64__) | ||
// FIXME: workaround for HLSL++ issue (https://github.com/redorav/hlslpp/issues/61): |
Check notice
Code scanning / CodeQL
FIXME comment
[[nodiscard]] bool operator>(const PointType& other) const noexcept | ||
{ | ||
#if defined(__APPLE__) && defined(__x86_64__) | ||
// FIXME: workaround for HLSL++ issue (https://github.com/redorav/hlslpp/issues/61): |
Check notice
Code scanning / CodeQL
FIXME comment
[[nodiscard]] bool operator<(const PointType& other) const noexcept | ||
{ | ||
#if defined(__APPLE__) && defined(__x86_64__) | ||
// FIXME: workaround for HLSL++ issue (https://github.com/redorav/hlslpp/issues/61): |
Check notice
Code scanning / CodeQL
FIXME comment
…ward compatibility
Kudos, SonarCloud Quality Gate passed! |
Kudos, SonarCloud Quality Gate passed! |
Kudos, SonarCloud Quality Gate passed! |
Methane Kit v0.6 Post-Release Hot-Fixes
PerlinNoise
withFastNoise2
library, but reverted it back because of no ARM support for M1 Macs (see FastNoise2 issue)METHANE_GPU_PROFILING_ENABLED=ON
:CommandList::Reset()
, while they should be cleared onCommandList::Commit()
.Context::Reset()
by always using deferred heap allocation in all cases. Deferred heap initialisation flag was removed, since it became unconditionally deferred.CommandQueueTrackingBase::WaitForExecution()
CommandQueueTrackingBase
with proper shutdown procedure called from destructor of derived class.Point<T,size>
wrapper class was extended with workarounds of MacOS & ARM specific bugs in HLSL++ integer vector comparison and division operators (see 1 and 2).Point
,Rect
andRectSize
values was added inDataTypes
unit tests.Build/Output/ExternalsCache
by default (it can be changed with CMake optionCPM_SOURCE_CACHE
).README.md
description of the external dependencies was added inExternals
directory.CMakeLists.txt
was simplified by moving all compiler configuration options toCMake/MethaneBuildOptions.cmake
.