Skip to content

Commit

Permalink
Enable Metal Argument Buffers as a primary binding mechanism by default
Browse files Browse the repository at this point in the history
  • Loading branch information
egorodet committed Dec 31, 2024
1 parent 45b6715 commit d0d7151
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Build/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ cmake -G [Generator] ... -D[BUILD_OPTION_NAME]:BOOL=[ON|OFF]
| <sub>METHANE_APPLE_CODE_SIGNING_ENABLED</sub> | <sub><em>OFF</em></sub> | <sub><em>OFF</em></sub> | <sub><b>OFF</b></sub> | <sub>Enable code signing on Apple platforms (requires APPLE_DEVELOPMENT_TEAM)</sub> |
| <sub>METHANE_METAL_FRAMES_SYNC_WITH_DISPATCH_SEMAPHORE</sub> | <sub><em>OFF</em></sub> | <sub><em>OFF</em></sub> | <sub><em>OFF</em></sub> | <sub>Enable Metal frame synchronization with dispatch semaphore instead of fence</sub> |
| <sub>METHANE_METAL_SHADER_CONVERTER_ENABLED</sub> | <sub><em>OFF</em></sub> | <sub><em>OFF</em></sub> | <sub><em>OFF</em></sub> | <sub>Enable Metal Shader Converter instead of SPIRV-Cross (Experimental)</sub> |
| <sub>METHANE_METAL_ARGUMENT_BUFFERS_ENABLED</sub> | <sub><em>OFF</em></sub> | <sub><em>OFF</em></sub> | <sub><em>OFF</em></sub> | <sub>Enable Metal Argument Buffers for shader bindings with SPIRV-Cross (Experimental)</sub> |
| <sub>METHANE_METAL_ARGUMENT_BUFFERS_ENABLED</sub> | <sub><em>ON</em></sub> | <sub><em>ON</em></sub> | <sub><em>ON</em></sub> | <sub>Enable Metal Argument Buffers for shader bindings with SPIRV-Cross (Experimental)</sub> |

### CMake Presets

Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ option(METHANE_OPEN_IMAGE_IO_ENABLED "Enable using OpenImageIO library fo
if(APPLE)
option(METHANE_METAL_FRAMES_SYNC_WITH_DISPATCH_SEMAPHORE "Enable Metal frame synchronization with dispatch semaphore instead of fence" OFF)
option(METHANE_METAL_SHADER_CONVERTER_ENABLED "Enable Apple Metal Shader Converter instead of SPIRV-Cross" OFF)
option(METHANE_METAL_ARGUMENT_BUFFERS_ENABLED "Enable Metal Argument Buffers for Program Resource Bindings" OFF)
option(METHANE_METAL_ARGUMENT_BUFFERS_ENABLED "Enable Metal Argument Buffers for Program Resource Bindings" ON)
endif()

# Profiling and instrumentation configuration
Expand Down
8 changes: 8 additions & 0 deletions CMakePresets.json
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,14 @@
"METHANE_APPLE_CODE_SIGNING_ENABLED": {
"type": "BOOL",
"value": "OFF"
},
"METHANE_METAL_SHADER_CONVERTER_ENABLED": {
"type": "BOOL",
"value": "OFF"
},
"METHANE_METAL_ARGUMENT_BUFFERS_ENABLED": {
"type": "BOOL",
"value": "ON"
}
}
},
Expand Down

0 comments on commit d0d7151

Please sign in to comment.