Amaroc 841 localized base height calculation #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regDaniel
commented
Aug 29, 2024
fpavogt
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Looks functional to me. I would add a bit more info to the docs, to help users understand why/when this parameter is useful, and what is the intended usage.
Side-question: should one add a page to the online docs to list all the major changes since v2.0.0 ? I.e. anything major that is not described in the ampycloud article ?
2 tasks
regDaniel
added a commit
that referenced
this pull request
Sep 4, 2024
* Add manual trigger for pypi release * Update copyright in tag * Upate citatiuon details * Fix typo * Fix format of CITATION.cff * Amaroc 841 localized base height calculation (#137) * AMAROC-835 add ceilo id query for base height calculation * AMAROC-835 request minimum amount of hits for base height calculation * AMAROC-841 localized cloud base height calculation * AMAROC-842 resolve version conflict * AMAROC-841 AMAROC-842 adapt changelog * AMAROC-841 raise warning if we do not filter but filter is set + adapt test * AMAROC-841 add documentation * AMAROC-841 fix doc referencing * AMAROC-841 exclude instead of keep ceilos (#140) * AMAROC-847 Set new release version (#141) --------- Co-authored-by: Frédéric P.A. Vogt <[email protected]>
regDaniel
added a commit
that referenced
this pull request
Oct 14, 2024
* Add manual trigger for pypi release * Update copyright in tag * Upate citatiuon details * Fix typo * Fix format of CITATION.cff * Amaroc 841 localized base height calculation (#137) * AMAROC-835 add ceilo id query for base height calculation * AMAROC-835 request minimum amount of hits for base height calculation * AMAROC-841 localized cloud base height calculation * AMAROC-842 resolve version conflict * AMAROC-841 AMAROC-842 adapt changelog * AMAROC-841 raise warning if we do not filter but filter is set + adapt test * AMAROC-841 add documentation * AMAROC-841 fix doc referencing * AMAROC-841 exclude instead of keep ceilos (#140) * AMAROC-847 Set new release version (#141) * AMAROC-848 update contribution guidelines / citation file (#143) * AMAROC-848 update contribution guidelines / citation file * AMAROC-848 update changelog * AMAROC-848 fix doc reference * AMAROC-848 fix bullet list * AMAROC-845 require statsmodels minimum 0.14.3 (#144) * AMAROC-863 set next patch version --------- Co-authored-by: Frédéric P.A. Vogt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Please add a brief summary of what this PR does.
Error(s) fixed:
Please tag them using
#, e.g.Fixed #42.Checklists: