Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modifiers to grabbed and restrained #209

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

cdverrett94
Copy link
Contributor

Closes #207

Applying the modifiers for grabbed and restrained. Added characteristic to the options on the rollCharacteristic method.

I added an isNotStatusSource to the AE class. I couldn't just use !isStatusSource because it would trigger even if the actor didn't have the status effect. I thought about adding an optional fourth parameter to reverse the status source check, but that seemed like the return would be confusing if isStatusSource returned true when they weren't the source. If you have a better idea on handling that, let me know.

@JPMeehan
Copy link
Contributor

usually the answer for a three-part state is false, null, and true - it's one of the reasons that _preCreate relies on an explicit return of false. Would that help?

@JPMeehan JPMeehan added the data model Document and Data Model issues label Jan 26, 2025
@cdverrett94
Copy link
Contributor Author

usually the answer for a three-part state is false, null, and true - it's one of the reasons that _preCreate relies on an explicit return of false. Would that help?

Yeah, that helps. Thanks for the advice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data model Document and Data Model issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grabbed and restrained need modifiers applied
2 participants