Add updated props for address component #2833
Open
+75
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david0xd
force-pushed
the
dd/modify-address-component
branch
from
408fe8b
to
b753e4d
Compare
7 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2833 +/- ##
=======================================
Coverage 94.44% 94.44%
=======================================
Files 484 484
Lines 10324 10324
Branches 1574 1574
=======================================
Hits 9751 9751
Misses 573 573 ☔ View full report in Codecov by Sentry. |
Mrtenz
reviewed
Oct 14, 2024
Comment on lines
13
to
15
| truncate?: boolean; | ||
| displayName?: boolean; | ||
| avatar?: boolean; |
There was a problem hiding this comment.
Suggested change
| truncate?: boolean; | |
| displayName?: boolean; | |
| avatar?: boolean; | |
| truncate?: boolean | undefined; | |
| displayName?: boolean | undefined; | |
| avatar?: boolean | undefined; |
GuillaumeRx
requested changes
Oct 14, 2024
GuillaumeRx
requested changes
Oct 14, 2024
david0xd
force-pushed
the
dd/modify-address-component
branch
from
5472339
to
2f47791
Compare
GuillaumeRx
reviewed
Oct 14, 2024
GuillaumeRx
reviewed
Oct 14, 2024
david0xd
force-pushed
the
dd/modify-address-component
branch
from
4f28526
to
d4d3769
Compare
GuillaumeRx
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update props of address component to get it work in more flexible way.
Integration PR for
metamask-extension: MetaMask/metamask-extension#27798Related ticket: #2758