-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Snap RPC wrappers #2332
Draft
FrederikBolding
wants to merge
5
commits into
main
Choose a base branch
from
fb/add-provider-wrapper
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add Snap RPC wrappers #2332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
force-pushed
the
fb/add-provider-wrapper
branch
from
April 16, 2024 15:09
3ff26c2
to
4e51108
Compare
@metamaskbot update-pr |
FrederikBolding
force-pushed
the
fb/add-provider-wrapper
branch
from
June 3, 2024 11:23
3b65264
to
7e1a831
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2332 +/- ##
==========================================
+ Coverage 94.38% 94.41% +0.02%
==========================================
Files 441 442 +1
Lines 9106 9148 +42
Branches 1405 1411 +6
==========================================
+ Hits 8595 8637 +42
Misses 511 511 ☔ View full report in Codecov by Sentry. |
@metamaskbot update-pr |
FrederikBolding
force-pushed
the
fb/add-provider-wrapper
branch
from
June 24, 2024 13:14
be35021
to
5096785
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add wrapper functions to the SDK for most of the RPC methods supported by
snap.request
.Fixes #2338