Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Recategorize controllers as peer dependencies #472

Merged
merged 1 commit into from
Nov 26, 2024

Commits on Nov 26, 2024

  1. chore: Recategorize controllers as peer dependencies

    The `@metamask/network-controller` and
    `@metamask/transaction-controller` dependencies have been moved from
    `dependencies` to `peerDependencies` (and `devDependencies`). This was
    done because we're not directly importing and using those controllers
    directly from imports, they're instead passed in as constructor
    parameters (indirectly), so it's critical that the versions we use here
    match the versions used on the client exactly.
    
    The peer dependency requirements of those two packages have been
    silenced because they aren't actually instantiated here, just used for
    type purposes (so we don't need their `peerDependencies` present).
    Gudahtt committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    3e64d70 View commit details
    Browse the repository at this point in the history