ADD: Mobile onboarding (Android & IOS) #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetaMask app will be opened in Play Store / App Store depending on the mobile device. Resolves #55
Gudahtt
reviewed
Nov 1, 2021
There was a problem hiding this comment.
Thanks for the contribution - this looks great! I've reviewed all of the changes, and everything here looks good to me.
I don't know whether this is the correct way to redirect users to the app stores, but I've asked the MetaMask mobile team to review and test that portion. Once they approve, and once the lint failures are addressed, this should be good to go.
| this._openDownloadPage(); | ||
| this._openForwarder(); | ||
| if (this.isPlatformDesktop) { | ||
| sessionStorage.setItem(REGISTRATION_IN_PROGRESS, 'true'); |
There was a problem hiding this comment.
Nit: Could you set this in both branches - both mobile and desktop? This is used to inform the wallet that onboarding has started. Mobile doesn't make use of this yet, but it will in the future.
alexanderramos89
approved these changes
Nov 2, 2021
Closed
alexanderramos89
approved these changes
Nov 3, 2021
|
Nevermind, we have implemented a custom solution internally. Thanks, anway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MetaMask app will be opened in Play Store / App Store depending on the mobile device.
Resolves #55