Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace Hermes with [email protected] and enable SES #8905

Closed
wants to merge 9 commits into from

Conversation

leotm
Copy link
Member

@leotm leotm commented Mar 12, 2024

Description

Gather perf metrics on Hermes vs JSC, noting

  • TTI
  • APK size
  • Memory consumption

cc @sethkfman

Gather metrics via BitRise performance flag

Nb: likely need to check on latest version of android-jsc for BigInt support

Related issues

Fixes:

Manual testing steps

Consider further metrics to BitRise via

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@leotm leotm changed the title experiement: Disable Hermes on Android feat: Disable Hermes on Android Mar 12, 2024
@leotm leotm added the android Android specific issue label Mar 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.58%. Comparing base (4bbbbac) to head (447b972).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8905      +/-   ##
==========================================
- Coverage   45.58%   45.58%   -0.01%     
==========================================
  Files        1276     1276              
  Lines       31302    31301       -1     
  Branches     3202     3201       -1     
==========================================
- Hits        14270    14269       -1     
  Misses      16186    16186              
  Partials      846      846              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

socket-security bot commented Mar 21, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 30.1 MB kudochien

View full report↗︎

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

+if (Platform.OS === 'ios' && !global?.HermesInternal) {
+ require('./setUpSes');
+}
+require('./setUpSes');
Copy link
Member Author

@leotm leotm Mar 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preserve !global?.HermesInternal condition
so enabling Hermes runs app w/o SES
until support lands

then we upgrade SES and remove the condition

@leotm
Copy link
Member Author

leotm commented Mar 26, 2024

build_android_qa (browserstack)

  • wdio cucumber report: jsc vs hermes(main)
    • +?s cold start (failing, todo: fix)
    • +1.7s cold start (after import wallet)
    • +0.07s warm start

build_android_release (physical devices)

  • sentry report perf: jsc vs hermes(prod)
    • +1.6s cold start

android 8.1-14

@leotm leotm closed this Mar 26, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2024
@leotm leotm changed the title feat: Disable Hermes on Android feat: Disable Hermes on Android and enable SES Mar 26, 2024
@leotm leotm changed the title feat: Disable Hermes on Android and enable SES feat: Replace Hermes with [email protected] and enable SES Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants