-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Replace Hermes with [email protected] and enable SES #8905
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8905 +/- ##
==========================================
- Coverage 45.58% 45.58% -0.01%
==========================================
Files 1276 1276
Lines 31302 31301 -1
Branches 3202 3201 -1
==========================================
- Hits 14270 14269 -1
Misses 16186 16186
Partials 846 846 ☔ View full report in Codecov by Sentry. |
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
Quality Gate passedIssues Measures |
+if (Platform.OS === 'ios' && !global?.HermesInternal) { | ||
+ require('./setUpSes'); | ||
+} | ||
+require('./setUpSes'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
preserve !global?.HermesInternal
condition
so enabling Hermes runs app w/o SES
until support lands
then we upgrade SES and remove the condition
build_android_qa (browserstack)
build_android_release (physical devices)
android 8.1-14 |
Description
Gather perf metrics on Hermes vs JSC, noting
cc @sethkfman
Gather metrics via BitRise performance flag
pr_regression_e2e_pipeline
android_build_regression_tests
onlyandroid_run_regression_tests
onlydetox: not found
, flakey?TEST_SUITE: 'Regression'
Nb: likely need to check on latest version of android-jsc for BigInt support
jsc-android
from250230.2.1
to294992.0.0
(@next
) forBigInt
#6314Related issues
Fixes:
Manual testing steps
Consider further metrics to BitRise via
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist