-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add microphone permissions to iOS (#7812) #7813
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/366df5d9-40c0-4e08-9137-e0bb4fe59d71 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7813 +/- ##
=======================================
Coverage 35.04% 35.04%
=======================================
Files 1040 1040
Lines 27710 27710
Branches 2344 2344
=======================================
Hits 9711 9711
Misses 17475 17475
Partials 524 524 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow cool, this was needed for some time! Cool! LGTM!
Kudos, SonarCloud Quality Gate passed! |
Tested, passed on my local simulator iPhone 13 Pro iOS 15.2. |
Description
This PR adds
NSMicrophoneUsageDescription
aka microphone access to iOS. This is meant to resolve crashers encountered by websites attempting to access microphone.Related issues
Fixes: #
Manual testing steps
Scenario 1
Install the build with microphone permission capabilities
Go to the mobile browser
Go to mictests.com
Press Test my mic
Allow microphone permissions
Microphone access is enabled and app does not crash
Scenario 2
Install the build with microphone permission capabilities
Go to the mobile browser
Go to mictests.com
Press Test my mic
Deny microphone permissions
Allow microphone permissions in phone settings
Reopen app and press test my mic
Microphone access is enabled and app does not crash
Screenshots/Recordings
Before
After
Scenario 1
https://github.com/MetaMask/metamask-mobile/assets/10508597/594446bf-d8ac-411c-b55d-2bc62bf3a1c2
Scenario 2
https://github.com/MetaMask/metamask-mobile/assets/10508597/94321ef8-70c8-4876-a91f-1fea9fbd02df
Pre-merge author checklist
Pre-merge reviewer checklist