Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add microphone permissions to iOS (#7812) #7813

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Nov 14, 2023

Description

This PR adds NSMicrophoneUsageDescription aka microphone access to iOS. This is meant to resolve crashers encountered by websites attempting to access microphone.

Related issues

Fixes: #

Manual testing steps

Scenario 1
Install the build with microphone permission capabilities
Go to the mobile browser
Go to mictests.com
Press Test my mic
Allow microphone permissions
Microphone access is enabled and app does not crash

Scenario 2
Install the build with microphone permission capabilities
Go to the mobile browser
Go to mictests.com
Press Test my mic
Deny microphone permissions
Allow microphone permissions in phone settings
Reopen app and press test my mic
Microphone access is enabled and app does not crash

Screenshots/Recordings

Before

After

Scenario 1
https://github.com/MetaMask/metamask-mobile/assets/10508597/594446bf-d8ac-411c-b55d-2bc62bf3a1c2

Scenario 2
https://github.com/MetaMask/metamask-mobile/assets/10508597/94321ef8-70c8-4876-a91f-1fea9fbd02df

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Cal-L Cal-L requested a review from a team as a code owner November 14, 2023 23:50
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 14, 2023
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/366df5d9-40c0-4e08-9137-e0bb4fe59d71
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@Cal-L
Copy link
Contributor Author

Cal-L commented Nov 14, 2023

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ca5a673) 35.04% compared to head (6881b43) 35.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7813   +/-   ##
=======================================
  Coverage   35.04%   35.04%           
=======================================
  Files        1040     1040           
  Lines       27710    27710           
  Branches     2344     2344           
=======================================
  Hits         9711     9711           
  Misses      17475    17475           
  Partials      524      524           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow cool, this was needed for some time! Cool! LGTM!

@metamaskbot metamaskbot added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Nov 15, 2023
@chrisleewilcox chrisleewilcox added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Nov 15, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@chrisleewilcox chrisleewilcox added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Nov 15, 2023
@chrisleewilcox
Copy link
Contributor

Tested, passed on my local simulator iPhone 13 Pro iOS 15.2.

@chrisleewilcox chrisleewilcox merged commit dd4a5ad into main Nov 15, 2023
29 checks passed
@chrisleewilcox chrisleewilcox deleted the fix/7812-ios-mic-crash branch November 15, 2023 22:48
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2023
@metamaskbot metamaskbot added the release-7.12.0 Issue or pull request that will be included in release 7.12.0 label Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done release-7.12.0 Issue or pull request that will be included in release 7.12.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants