Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Move TestIDs from page objects in e2e/pages folder #7762

Merged
merged 28 commits into from
Nov 16, 2023

Conversation

SamuelSalas
Copy link
Contributor

Description

Relocate the TestIDs from each page object to their corresponding testID file within the testID folder. This task is aimed at transferring the TestIDs from the page objects in the e2e/pages folder.

Related issues

Fixes: #7721

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@SamuelSalas SamuelSalas requested a review from a team as a code owner November 10, 2023 17:38
@SamuelSalas SamuelSalas linked an issue Nov 10, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6d53495) 35.04% compared to head (4ea91cc) 34.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7762      +/-   ##
==========================================
- Coverage   35.04%   34.98%   -0.07%     
==========================================
  Files        1041     1040       -1     
  Lines       27716    27690      -26     
  Branches     2345     2345              
==========================================
- Hits         9712     9686      -26     
  Misses      17480    17480              
  Partials      524      524              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot metamaskbot added in-progress needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed in-progress labels Nov 14, 2023
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

chrisleewilcox
chrisleewilcox previously approved these changes Nov 15, 2023
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

e2e/pages/WalletView.js Show resolved Hide resolved
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments.

.tool-versions Outdated Show resolved Hide resolved
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only left one small comment. Also, run the regression pipeline in addition to the smoke pipeline on this PR.

e2e/specs/browser/browser-tests.spec.js Outdated Show resolved Hide resolved
@SamuelSalas
Copy link
Contributor Author

I only left one small comment. Also, run the regression pipeline in addition to the smoke pipeline on this PR.

@SamuelSalas SamuelSalas reopened this Nov 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 16, 2023
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/17d4a5f0-aa07-4d92-bca8-cc8951cf3050
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@github-actions github-actions bot unlocked this conversation Nov 16, 2023
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ ✅ ✅

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@SamuelSalas SamuelSalas merged commit 3e5c9da into main Nov 16, 2023
26 checks passed
@SamuelSalas SamuelSalas deleted the test/7721-move-testids-pages-folder branch November 16, 2023 22:55
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2023
@metamaskbot metamaskbot added the release-7.12.0 Issue or pull request that will be included in release 7.12.0 label Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.12.0 Issue or pull request that will be included in release 7.12.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move TestIDs from page objects in e2e/pages folder
6 participants