Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix network badge merge issue #7750

Merged
merged 2 commits into from
Nov 10, 2023
Merged

fix: Fix network badge merge issue #7750

merged 2 commits into from
Nov 10, 2023

Conversation

brianacnguyen
Copy link
Contributor

@brianacnguyen brianacnguyen commented Nov 10, 2023

Description

  • This PR removed changes made with this PR. This PR combined both changes

Related issues

Fixes: #

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Run Smoke E2E labels Nov 10, 2023
@brianacnguyen brianacnguyen self-assigned this Nov 10, 2023
@brianacnguyen brianacnguyen requested a review from a team as a code owner November 10, 2023 00:29
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9669d257-6aeb-4e64-add9-4feffe69f459
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@brianacnguyen brianacnguyen added the team-design-system All issues relating to design system in Mobile label Nov 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7c1b78e) 35.10% compared to head (13fd421) 35.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7750   +/-   ##
=======================================
  Coverage   35.10%   35.10%           
=======================================
  Files        1039     1039           
  Lines       27617    27619    +2     
  Branches     2336     2336           
=======================================
+ Hits         9694     9695    +1     
- Misses      17400    17401    +1     
  Partials      523      523           
Files Coverage Δ
...components/Pickers/PickerNetwork/PickerNetwork.tsx 100.00% <ø> (ø)
...s/Pickers/PickerNetwork/PickerNetwork.constants.ts 66.66% <66.66%> (-33.34%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@brianacnguyen brianacnguyen merged commit e821b6e into main Nov 10, 2023
29 of 30 checks passed
@brianacnguyen brianacnguyen deleted the fix/picker branch November 10, 2023 00:47
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 10, 2023
@metamaskbot metamaskbot added the release-7.12.0 Issue or pull request that will be included in release 7.12.0 label Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.12.0 Issue or pull request that will be included in release 7.12.0 team-design-system All issues relating to design system in Mobile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants