Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade jsc-android from 250230.2.1 to 294992.0.0 (@next) for BigInt #6314

Closed
wants to merge 5 commits into from

Commits on May 2, 2023

  1. Upgrade from jsc-android 250230.2.1 to 294992.0.0 (next) for BigInt

    - react-native-community/jsc-android-buildscripts#159 (comment)
    - facebook/react-native#35504 (comment)
    - vanilla RN 0.71.6 tested working: 1n+2n, BigInt(1)+BigInt(2)
    - package.json>resolution not required (result: resolution field incompatible)
    - org.webkit:android-jsc-intl:+ required (which we're already using)
    
    294992.0.0 prevents need for e.g. `big-integer` shim, till RN 0.71.6 shipped
    #6221
    
    294992.0.0 prevents need for BE patches, till RN 0.71.6 upgrade shipped
    e.g. #6305 cc @Cal-L
    
    But (the catch) 294992.0.0 results in repo-specific dep build error,
    possibly more deps to resolve, likely via patch(es):
    
    > Configure project :react-native-reanimated
    No AAR for react-native-reanimated found. Attempting to build from source.
    Android gradle plugin: 4.2.2
    Gradle: 6.9
    
    Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
    Use '--warning-mode all' to show the individual deprecation warnings.
    See https://docs.gradle.org/6.9/userguide/command_line_interface.html#sec:command_line_warnings
    Error: Command failed: ./gradlew app:installProdDebug -PreactNativeDevServerPort=8081
    OpenJDK 64-Bit Server VM warning: Ignoring option MaxPermSize; support was removed in 8.0
    Warning: Mapping new ns http://schemas.android.com/repository/android/common/02 to old ns http://schemas.android.com/repository/android/common/01
    Warning: Mapping new ns http://schemas.android.com/repository/android/generic/02 to old ns http://schemas.android.com/repository/android/generic/01
    Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/addon2/02 to old ns http://schemas.android.com/sdk/android/repo/addon2/01
    Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/addon2/03 to old ns http://schemas.android.com/sdk/android/repo/addon2/01
    Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/repository2/02 to old ns http://schemas.android.com/sdk/android/repo/repository2/01
    Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/repository2/03 to old ns http://schemas.android.com/sdk/android/repo/repository2/01
    Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/sys-img2/03 to old ns http://schemas.android.com/sdk/android/repo/sys-img2/01
    Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/sys-img2/02 to old ns http://schemas.android.com/sdk/android/repo/sys-img2/01
    
    FAILURE: Build failed with an exception.
    
    * Where:
    Build file '/Users/leo/Documents/GitHub/metamask-mobile/node_modules/react-native-reanimated/android/build.gradle' line: 1059
    
    * What went wrong:
    A problem occurred evaluating project ':react-native-reanimated'.
    > Expected directory '/Users/leo/Documents/GitHub/metamask-mobile/node_modules/react-native/../jsc-android/dist/org/webkit/android-jsc' to contain exactly one file, however, it contains no files.
    leotm committed May 2, 2023
    Configuration menu
    Copy the full SHA
    1345d18 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Configuration menu
    Copy the full SHA
    3a82956 View commit details
    Browse the repository at this point in the history
  2. Switch off Hermes on Android

    leotm committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    0300fdf View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    86c2804 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2023

  1. Configuration menu
    Copy the full SHA
    24fd57a View commit details
    Browse the repository at this point in the history