test: remove AfterAll hook in e2e

[cortisiko]

Description

The editRecipient test is failing on main with the following error:

AggregateError: 
    at Function.Object.<anonymous>.AxiosError.from (/Users/vagrant/git/node_modules/axios/lib/core/AxiosError.js:89:14)
    at RedirectableRequest.handleRequestError (/Users/vagrant/git/node_modules/axios/lib/adapters/http.js:620:25)
    at RedirectableRequest.emit (node:events:519:28)
    at ClientRequest.eventHandlers.<computed> (/Users/vagrant/git/node_modules/follow-redirects/index.js:38:24)
    at ClientRequest.emit (node:events:519:28)
    at emitErrorEvent (node:_http_client:101:11)
    at Socket.socketErrorListener (node:_http_client:504:5)
    at Socket.emit (node:events:519:28)
    at emitErrorNT (node:internal/streams/destroy:169:8)
    at emitErrorCloseNT (node:internal/streams/destroy:128:3)
    at processTicksAndRejections (node:internal/process/task_queues:82:21)
    at Axios.request (/Users/vagrant/git/node_modules/axios/lib/core/Axios.js:45:41)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

After digging into the code a bit, we are trying to stop the fixture server twice. Once in the AfterAll hook and the other time when we use withFixtures where in the try-catch-finally ... specifically the finally block.

This PR removes the afterAll hook in the test

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e5321fe
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/95252e9a-d1dd-4bc4-9ca0-270cebd0a02c

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.73%. Comparing base (2ce6596) to head (e5321fe).
Report is 6 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13183      +/-   ##
==========================================
+ Coverage   60.58%   60.73%   +0.15%     
==========================================
  Files        1911     1915       +4     
  Lines       42759    42805      +46     
  Branches     5740     5749       +9     
==========================================
+ Hits        25904    25998      +94     
+ Misses      15105    15059      -46     
+ Partials     1750     1748       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[chrisleewilcox]

LGTM