Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove thrown Error for logging in Sentry on unrecognized network switch #13182

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

frankvonhoven
Copy link
Contributor

@frankvonhoven frankvonhoven commented Jan 24, 2025

Description

Don't throw and Error on unrecognized network, just report it to Sentry

Related issues

Fixes: #11731

Manual testing steps

In in-app browser:

  1. Go to https://bridge.coredao.org/coreBTC
  2. Click on "Add coreBTC to your wallet"
  3. MM should log in Sentry "Unrecognized chain ID "0x45c". Try adding the chain using wallet_addEthereumChain first."

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@frankvonhoven frankvonhoven requested review from a team as code owners January 24, 2025 21:47
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@frankvonhoven frankvonhoven added team-mobile-platform No QA Needed Apply this label when your PR does not need any QA effort. labels Jan 24, 2025
Copy link

@frankvonhoven frankvonhoven added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 24, 2025
Copy link
Contributor

github-actions bot commented Jan 24, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e8416a3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a89fbc71-2b7e-4172-a6f4-97280f8357e7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@frankvonhoven frankvonhoven added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Stop throwing error in Sentry when user tries to add a chain with unrecognized rpc url
1 participant