feat: Add Solana account (Flask only) #13160

owencraston · 2025-01-23T21:22:16Z

Description

pre installed the Solana Wallet Snap on mobile
include it in the list of pre installed snaps
add method to trigger the Solana snap
added copy for adding a solana account
added the account actions to add a solana account
added selectors/functions to determine if the user has solana enabled (default to true on flask) and if they have already created a solana account
allow user to add a solana account under the following conditions
- the client is in flask mode
- solana is enabled (default to true on flask)
- the user has not already created a solana account
When the current selected account is Solana, we render the network as Solana and make it non selectable (same as we did for Bitcoin until we deal with the MultichainNetworks).

This PR does not...

render balances properly
disable token list on non evm chains
disable dapp connections on non evm chains

Extension references:

Related issues

Similar to the Bitcoin work done in this PR

Fixes: https://github.com/MetaMask/accounts-planning/issues/807

Manual testing steps

checkout this branch
open .js.env
set export METAMASK_BUILD_TYPE="flask" // flask
source .js.env
yarn setup
yarn start:ios
create/import a wallet
open the account menu actions
you should see that you can add a solana account along with a BTC and BTC testnet account
click Add a new Solana account (Beta)
a popup with a suggested name should appear
click confirm
the newly selected account should be your Solana account and the network picker should show the Solana logo
the network should not be clickable
open up the account actions again and notice that you can add another Sol account. This is different from Bitcoin which can only support one account.
repeat these steps with bitcoin

Testing Production

reset your wallet
reset your .js.env to have METAMASK_BUILD_TYPE = 'main'
rebuild the app
create/import wallet
open the account actions
there should be no mention of Bitcoin or Solana
there should be no snaps section in the settings

Screenshots/Recordings

After

Screen.Recording.2025-01-23.at.3.47.35.PM.mov

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-01-23T21:22:31Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2025-01-23T21:25:05Z

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected]	None	`0`	1.48 MB	metamaskbot
npm/@metamask/[email protected]	network	`0`	1.96 MB	metamaskbot
npm/@solana/[email protected]	None	`0`	198 kB	lorisleiva
npm/@solana/[email protected]	None	`0`	51.4 kB	lorisleiva
npm/@solana/[email protected]	None	`0`	495 kB	lorisleiva
npm/@solana/[email protected]	None	`0`	246 kB	lorisleiva
npm/@solana/[email protected]	None	`0`	208 kB	lorisleiva
npm/@solana/[email protected]	None	`0`	1.35 MB	lorisleiva
npm/[email protected]	environment	`0`	186 kB	abetomo

View full report↗︎

socket-security · 2025-01-23T21:25:07Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@metamask/[email protected], npm/@metamask/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

app/reducers/multichain/index.ts

github-actions · 2025-01-23T23:45:31Z

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: c219b29
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/988d67d3-7d8b-4b6f-b058-ccd4f9582959

Note

This comment will auto-update when build completes
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

tommasini

LGTM

app/components/UI/Navbar/index.js

owencraston · 2025-01-24T00:02:52Z

@SocketSecurity ignore npm/@metamask/[email protected]
@SocketSecurity ignore npm/@metamask/[email protected]

These are both internal metamask packages.

.nvmrc

github-actions · 2025-01-24T00:17:08Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5939524
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f16c1fbd-eb2c-4188-aa80-ae222d0e3f1d

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2025-01-24T01:12:49Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d42794d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c58b68b5-cc82-485e-aa15-dd3cfd22ac23

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

aganglada

GREAT work! 🎉
QQ, how is the flask build code fence called, how come we are using keyring-snaps

.nvmrc

app/components/Views/AddAccountActions/AddAccountActions.test.tsx

app/core/Multichain/test/utils.test.ts

app/selectors/accountsController.ts

locales/languages/en.json

package.json

github-actions · 2025-01-24T18:49:57Z

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: d80e63d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6ba896f3-3612-451c-8da7-d1bb45a4a120

Note

This comment will auto-update when build completes
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2025-01-24T18:59:25Z

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 2a3ae96
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8e935e92-6bf5-4617-9c74-7df43c528209

Note

This comment will auto-update when build completes
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

owencraston · 2025-01-24T19:06:00Z

@aganglada It works by using this shared custom library inside the metro.transform file. In that file we define the flags that are supported on flask vs main.

github-actions · 2025-01-24T19:15:34Z

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 28a35f6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e6595176-041f-4335-9752-0f7c5d3d1869

Note

This comment will auto-update when build completes
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

owencraston · 2025-01-24T19:27:20Z

Screen.Recording.2025-01-24.at.11.25.18.AM.mov

github-actions · 2025-01-24T19:42:13Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 867e639
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/113e0d60-c7ce-4038-9ff6-92b6c90d775d

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

sonarqubecloud · 2025-01-24T19:49:41Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

owencraston commented Jan 23, 2025

View reviewed changes

app/reducers/multichain/index.ts Show resolved Hide resolved

owencraston marked this pull request as ready for review January 23, 2025 23:44

owencraston requested review from a team as code owners January 23, 2025 23:44

owencraston added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 23, 2025

tommasini previously approved these changes Jan 23, 2025

View reviewed changes

app/components/UI/Navbar/index.js Show resolved Hide resolved

owencraston added the team-accounts label Jan 23, 2025

owencraston commented Jan 24, 2025

View reviewed changes

.nvmrc Show resolved Hide resolved

owencraston dismissed tommasini’s stale review via 5939524 January 24, 2025 00:16

owencraston added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 24, 2025

tommasini previously approved these changes Jan 24, 2025

View reviewed changes

owencraston enabled auto-merge January 24, 2025 00:31

owencraston dismissed tommasini’s stale review via d42794d January 24, 2025 01:11

owencraston added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 24, 2025

tommasini previously approved these changes Jan 24, 2025

View reviewed changes

owencraston added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 24, 2025

FrederikBolding previously approved these changes Jan 24, 2025

View reviewed changes

aganglada previously approved these changes Jan 24, 2025

View reviewed changes

ccharly reviewed Jan 24, 2025

View reviewed changes

owencraston dismissed tommasini’s stale review via 01e89cc January 24, 2025 18:37

owencraston force-pushed the feat/add-solana-accounts branch from d42794d to 01e89cc Compare January 24, 2025 18:37

no longer need to check if user has created solana accounts

d80e63d

owencraston added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 24, 2025

remove broken test

2a3ae96

owencraston added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 24, 2025

add back isSolanaAccount

28a35f6

owencraston added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 24, 2025

improve test coverage

867e639

aganglada approved these changes Jan 24, 2025

View reviewed changes

owencraston added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 24, 2025

tommasini approved these changes Jan 24, 2025

View reviewed changes

FrederikBolding approved these changes Jan 24, 2025

View reviewed changes

owencraston added this pull request to the merge queue Jan 24, 2025

Merged via the queue into main with commit 6e2d9cf Jan 24, 2025
42 of 43 checks passed

owencraston deleted the feat/add-solana-accounts branch January 24, 2025 20:37

github-actions bot locked and limited conversation to collaborators Jan 24, 2025

metamaskbot added the release-7.40.0 Issue or pull request that will be included in release 7.40.0 label Jan 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add Solana account (Flask only) #13160

feat: Add Solana account (Flask only) #13160

owencraston commented Jan 23, 2025 •

edited

Loading

github-actions bot commented Jan 23, 2025

socket-security bot commented Jan 23, 2025 •

edited

Loading

socket-security bot commented Jan 23, 2025 •

edited

Loading

github-actions bot commented Jan 23, 2025

tommasini left a comment

owencraston commented Jan 24, 2025

github-actions bot commented Jan 24, 2025 •

edited by metamaskbot

Loading

github-actions bot commented Jan 24, 2025 •

edited by metamaskbot

Loading

aganglada left a comment •

edited

Loading

github-actions bot commented Jan 24, 2025

github-actions bot commented Jan 24, 2025

owencraston commented Jan 24, 2025

github-actions bot commented Jan 24, 2025

owencraston commented Jan 24, 2025

github-actions bot commented Jan 24, 2025 •

edited by metamaskbot

Loading

sonarqubecloud bot commented Jan 24, 2025

feat: Add Solana account (Flask only) #13160

feat: Add Solana account (Flask only) #13160

Conversation

owencraston commented Jan 23, 2025 • edited Loading

Description

Related issues

Manual testing steps

Testing Production

Screenshots/Recordings

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jan 23, 2025

socket-security bot commented Jan 23, 2025 • edited Loading

socket-security bot commented Jan 23, 2025 • edited Loading

Next steps

github-actions bot commented Jan 23, 2025

Bitrise

tommasini left a comment

Choose a reason for hiding this comment

owencraston commented Jan 24, 2025

github-actions bot commented Jan 24, 2025 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Jan 24, 2025 • edited by metamaskbot Loading

Bitrise

aganglada left a comment • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Jan 24, 2025

Bitrise

github-actions bot commented Jan 24, 2025

Bitrise

owencraston commented Jan 24, 2025

github-actions bot commented Jan 24, 2025

Bitrise

owencraston commented Jan 24, 2025

github-actions bot commented Jan 24, 2025 • edited by metamaskbot Loading

Bitrise

sonarqubecloud bot commented Jan 24, 2025

Quality Gate passed

owencraston commented Jan 23, 2025 •

edited

Loading

socket-security bot commented Jan 23, 2025 •

edited

Loading

socket-security bot commented Jan 23, 2025 •

edited

Loading

github-actions bot commented Jan 24, 2025 •

edited by metamaskbot

Loading

github-actions bot commented Jan 24, 2025 •

edited by metamaskbot

Loading

aganglada left a comment •

edited

Loading

github-actions bot commented Jan 24, 2025 •

edited by metamaskbot

Loading