Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrading to design tokens v5.0.0 #13157

Merged
merged 4 commits into from
Jan 24, 2025
Merged

Conversation

georgewrmarshall
Copy link
Contributor

@georgewrmarshall georgewrmarshall commented Jan 23, 2025

Description

This PR upgrades the design tokens package to version 5.0.0, which includes a darker dark mode and fixes type definitions unintentionally broken in version 4.2.0.

  • Ensures compatibility with the latest design tokens and aligns colors with the extension and portfolio.
  • Updates snapshots to reflect new color changes and somewhat unfortunately just case changing of the hex values to uppercase.
  • Simplifies type imports, replacing deep linking with a cleaner format.

Related issues

Fixes: #13107

Manual testing steps

This pull request updates a lot of snapshots so an effective way to review is to filter out snapshots from Files changed view and:

  1. Ensure correct design tokens version 5.0.0 has been updated in the package.json and yarn.lock
  2. Ensure all types have been updated to be imported from '@metamask/design-tokens'

To review color updates

  1. Pull the branch and install dependencies.
  2. Navigate around the app in both light and especially dark mode
  3. Check UI doesn't have any color abnormalities

Screenshots/Recordings

Before

before720.mov

After

after.mov

Checking no deep linked type imports remain by searching from '@metamask/design-tokens/ to ensure all imports are correct

Screenshot 2025-01-23 at 1 20 09 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g., pulled and built branch, ran the app, tested the code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and/or screenshots.

@georgewrmarshall georgewrmarshall self-assigned this Jan 23, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-design-system All issues relating to design system in Mobile label Jan 23, 2025
@georgewrmarshall georgewrmarshall added No QA Needed Apply this label when your PR does not need any QA effort. No E2E Smoke Needed If the PR does not need E2E smoke test run labels Jan 23, 2025
Copy link

socket-security bot commented Jan 23, 2025

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected] None 0 292 kB metamaskbot

View full report↗︎

@georgewrmarshall georgewrmarshall force-pushed the design-tokens-5.0.0 branch 2 times, most recently from 998268a to 7887460 Compare January 23, 2025 21:09
tsconfig.json Outdated Show resolved Hide resolved
@georgewrmarshall georgewrmarshall marked this pull request as ready for review January 23, 2025 21:45
@georgewrmarshall georgewrmarshall requested review from a team as code owners January 23, 2025 21:45
brianacnguyen
brianacnguyen previously approved these changes Jan 23, 2025
sleepytanya
sleepytanya previously approved these changes Jan 24, 2025
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@christopherferreira9 christopherferreira9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georgewrmarshall georgewrmarshall added this pull request to the merge queue Jan 24, 2025
Merged via the queue into main with commit 6b5e23f Jan 24, 2025
39 checks passed
@georgewrmarshall georgewrmarshall deleted the design-tokens-5.0.0 branch January 24, 2025 21:00
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2025
@metamaskbot metamaskbot added the release-7.40.0 Issue or pull request that will be included in release 7.40.0 label Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. release-7.40.0 Issue or pull request that will be included in release 7.40.0 team-design-system All issues relating to design system in Mobile
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Upgrade design tokens to 5.0.0