-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrading to design tokens v5.0.0 #13157
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
da3c64b
to
dda6413
Compare
998268a
to
7887460
Compare
7887460
to
ccf2499
Compare
cd546c3
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR upgrades the design tokens package to version 5.0.0, which includes a darker dark mode and fixes type definitions unintentionally broken in version
4.2.0
.Related issues
Fixes: #13107
Manual testing steps
This pull request updates a lot of snapshots so an effective way to review is to filter out snapshots from Files changed view and:
package.json
andyarn.lock
from '@metamask/design-tokens'
To review color updates
Screenshots/Recordings
Before
before720.mov
After
after.mov
Checking no deep linked type imports remain by searching
from '@metamask/design-tokens/
to ensure all imports are correctPre-merge author checklist
Pre-merge reviewer checklist