Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: STAKE-929 build token list item component #13154

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: STAKE-929 build token list item component #13154

wants to merge 1 commit into from
+393 −0

Conversation

Matt561
Copy link
Contributor

@Matt561 Matt561 commented Jan 23, 2025 •
edited
Loading

Description

Added generic <TokenListItem /> for use in Staking flows.

Related issues

Fixes: STAKE-929: build token list item component

Manual testing steps

N/A

Screenshots/Recordings

Before

N/A

After

Default

image

Styled Primary and Secondary Text

image

Primary Text only

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Matt561 Matt561 added team-stake Run Smoke E2E Triggers smoke e2e on Bitrise and removed team-identity labels Jan 23, 2025
@github-actions GitHub Actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 931ed4e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0ebc267c-6175-493f-b4da-7d2bb11d3b75

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Matt561 Matt561 marked this pull request as ready for review January 23, 2025 17:22
@Matt561 Matt561 requested a review from a team as a code owner January 23, 2025 17:22
@Matt561 Matt561 force-pushed the feat/stake-929-build-token-list-item-component branch from 931ed4e to 7af492e Compare January 23, 2025 17:25
@Matt561 Matt561 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 23, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 23, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7af492e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6e89ae8b-b2c1-4978-ba59-72163dd1e024

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-stake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Matt561 @metamaskbot