Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: toast msg on deleted network #13146

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

sahar-fehri
Copy link
Contributor

Description

PR to fix toast msg when a network is deleted

Related issues

Fixes:

Manual testing steps

  1. Click on network selector
  2. Delete any network
  3. toast msg should day '... successfully deleted' instead of 'successfully added'

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Jan 23, 2025
@sahar-fehri sahar-fehri changed the title Fix/fix toast msg on deleted network fix: toast msg on deleted network Jan 23, 2025
@sahar-fehri sahar-fehri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 23, 2025
Copy link
Contributor

github-actions bot commented Jan 23, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4e90ca9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6aae41e1-54d4-436b-9214-f38ba4cb22e5

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 23, 2025
@sahar-fehri sahar-fehri marked this pull request as ready for review January 23, 2025 23:18
@sahar-fehri sahar-fehri requested a review from a team as a code owner January 23, 2025 23:18
@sahar-fehri sahar-fehri added this pull request to the merge queue Jan 24, 2025
Merged via the queue into main with commit 3f5ebcb Jan 24, 2025
52 of 55 checks passed
@sahar-fehri sahar-fehri deleted the fix/fix-toast-msg-on-deleted-network branch January 24, 2025 10:44
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2025
@metamaskbot metamaskbot added the release-7.40.0 Issue or pull request that will be included in release 7.40.0 label Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-7.40.0 Issue or pull request that will be included in release 7.40.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants