Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hide simulation section in typed sign v1 pages #13139

Merged
merged 5 commits into from
Jan 23, 2025
Merged

fix: Hide simulation section in typed sign v1 pages #13139

merged 5 commits into from
Jan 23, 2025

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Jan 23, 2025

Description

Simulation section should not be displayed on typed sign V1 page.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4012

Manual testing steps

  1. Go to test dapp
  2. Submit type sign request
  3. Ensure that simulation section is not present

Screenshots/Recordings

Before

Screenshot 2025-01-23 at 7 02 52 PM

After

Screenshot 2025-01-23 at 7 08 27 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Jan 23, 2025
@jpuri jpuri requested a review from a team as a code owner January 23, 2025 13:35
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 23, 2025
Copy link
Contributor

github-actions bot commented Jan 23, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5b6021a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/83230f02-3842-4ae5-b085-c5954df88ef3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

digiwand
digiwand previously approved these changes Jan 23, 2025
@jpuri jpuri enabled auto-merge January 23, 2025 15:10
@jpuri jpuri added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit afbd917 Jan 23, 2025
37 of 38 checks passed
@jpuri jpuri deleted the type_v1_fix branch January 23, 2025 15:35
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2025
@metamaskbot metamaskbot added the release-7.40.0 Issue or pull request that will be included in release 7.40.0 label Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.40.0 Issue or pull request that will be included in release 7.40.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants