Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: blockaid validations are not being flagged in re-designed signature request pages #13092

Merged
merged 13 commits into from
Jan 22, 2025

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Jan 21, 2025

Description

fix for blockaid validations are not being flagged in re-designed signature request pages

Related issues

Fixes: #13068

Manual testing steps

  1. To to test dapp
  2. Submit malicious permit
  3. Check blockaid banner on the page

Screenshots/Recordings

Screenshot 2025-01-21 at 11 24 39 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Jan 21, 2025
@jpuri jpuri requested review from a team as code owners January 21, 2025 12:14
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 21, 2025
Copy link
Contributor

github-actions bot commented Jan 21, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7750bf3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/482fc371-36f8-4918-9150-907306ed8efc

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.02%. Comparing base (faf5340) to head (5a89af0).
Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
...s/Views/confirmations/hooks/useSignatureMetrics.ts 66.66% 1 Missing ⚠️
...ents/Views/confirmations/utils/signatureMetrics.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13092      +/-   ##
==========================================
+ Coverage   59.83%   60.02%   +0.18%     
==========================================
  Files        1873     1894      +21     
  Lines       42121    42482     +361     
  Branches     5473     5608     +135     
==========================================
+ Hits        25204    25500     +296     
- Misses      15235    15255      +20     
- Partials     1682     1727      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 21, 2025
Copy link
Contributor

github-actions bot commented Jan 21, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a4ba657
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6de63ed3-0a0f-4e2f-82fd-9b33291c69e6

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 22, 2025
Copy link
Contributor

github-actions bot commented Jan 22, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 23b6627
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ccd58ee6-6cbd-408d-916e-b9c969818057

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 22, 2025
Copy link
Contributor

github-actions bot commented Jan 22, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ab6f0d4
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4cc54c0c-c0d7-42c3-a23f-74680f6f65f0

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@jpuri jpuri enabled auto-merge January 22, 2025 11:41
@jpuri jpuri added this pull request to the merge queue Jan 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 22, 2025
@jpuri jpuri added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit e0a50f6 Jan 22, 2025
41 of 42 checks passed
@jpuri jpuri deleted the blockaid_fix branch January 22, 2025 12:12
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2025
@metamaskbot metamaskbot added the release-7.40.0 Issue or pull request that will be included in release 7.40.0 label Jan 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.40.0 Issue or pull request that will be included in release 7.40.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Malicious permits are not flagged
5 participants