You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix precision across mobile transaction values. JavaScript Number coerces values into scientific notation which looses precision when rendering full values
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
digiwand
changed the title
fix: value precision for simulation and other cases using calcTokenAm…
fix: Precision of BigNumber values shown in transaction and signature pages
Jan 16, 2025
Thanks for the reviews! Thanks for the reminder about creating tests @matthewwalsh0! Created a test and found we had an issue supporting the test case supporting 36 decimals. Updated BigNumber configuration to support 36 decimals as we did in the extension here: MetaMask/metamask-extension#21147
digiwand
changed the title
fix: Precision of BigNumber values shown in transaction and signature pages
fix: Precision of BigNumber values of calcTokenAmount and Configure BigNumber to support 36 decimals
Jan 16, 2025
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
digiwand
changed the title
metamaskbot
added
the
release-7.39.0
Description
Fix precision across mobile transaction values. JavaScript Number coerces values into scientific notation which looses precision when rendering full values
Update BigNumber.config to support 36 decimals similarly to MetaMask/metamask-extension#21147
Related issues
Fixes: #12991
Relates to: #12994
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist