Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Chore/update png mock for tests #12975

Merged
merged 5 commits into from
Jan 15, 2025
Merged

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Jan 14, 2025

Description

This PR updates the png mock used in tests to return a number, which is the type that React Native returns when assets are required. All of the changes in this PR are snapshot updates

Related issues

Fixes:

Manual testing steps

Unit tests should all pass

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Cal-L Cal-L requested review from a team as code owners January 14, 2025 08:59
@Cal-L Cal-L self-assigned this Jan 14, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed Apply this label when your PR does not need any QA effort. No E2E Smoke Needed If the PR does not need E2E smoke test run labels Jan 14, 2025
@Cal-L Cal-L enabled auto-merge January 14, 2025 09:05
Copy link
Contributor

@salimtb salimtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Matt561 Matt561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed staking changes. LGTM!

Copy link
Contributor

@vinnyhoward vinnyhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Cal-L Cal-L added this pull request to the merge queue Jan 15, 2025
Merged via the queue into main with commit 00bc6d3 Jan 15, 2025
37 checks passed
@Cal-L Cal-L deleted the chore/update-png-mock-for-tests branch January 15, 2025 19:45
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 15, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2025
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. release-7.39.0 Issue or pull request that will be included in release 7.39.0 team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

10 participants