Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed getStakingNavbar broken back and cancel buttons regression #12920

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

Matt561
Copy link
Contributor

@Matt561 Matt561 commented Jan 9, 2025

Description

This PR fixes a recently introduced regression that broke the "back" and "cancel" buttons when using getStakingNavbar(). This only impacted the staking views.

Related issues

Manual testing steps

Stake Input Screen (broken cancel navbar button)

  1. Set MM_POOLED_STAKING_UI_ENABLED to true in .js.env
  2. Click "Ethereum" from the token list (home screen)
  3. Click on the "Stake" or "Stake more" button (the same can be tested for the unstake flow if you have ETH staked)
  4. From the Staking Input View, click the "Cancel" button in the top-right corner.
  5. You should be redirected to the previous screen (Ethereum details)

Stake Confirmation Screen (broken back navbar button)

  1. Set MM_POOLED_STAKING_UI_ENABLED to true in .js.env
  2. Click "Ethereum" from the token list (home screen)
  3. Click on the "Stake" or "Stake more" button (the same can be tested for the unstake flow if you have ETH staked)
  4. Enter a valid amount and press "Review" to view the stake confirmation screen.
  5. Click the "back" button in the top-left corner in the navbar
  6. You should be redirected to the previous screen (stake input screen)

Screenshots/Recordings

Before

getStakingNavbar-regression-fix-before.mov

After

getStakingNavbar-regression-fix-after.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Matt561 Matt561 marked this pull request as ready for review January 9, 2025 23:03
@Matt561 Matt561 requested a review from a team as a code owner January 9, 2025 23:03
@Matt561 Matt561 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed team-identity labels Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5c79582
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e9832dbd-0bb0-4fcc-b0fa-b9dc0bcb003d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Matt561 Matt561 requested a review from amitabh94 January 9, 2025 23:06
Copy link

sonarqubecloud bot commented Jan 9, 2025

Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮

@Matt561 Matt561 added this pull request to the merge queue Jan 10, 2025
Merged via the queue into main with commit 96c22e2 Jan 10, 2025
48 of 52 checks passed
@Matt561 Matt561 deleted the fix/stake-navbar-buttons-regression branch January 10, 2025 01:42
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2025
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-stake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants