fix: Bump artifact upload and download version to 4

[Cal-L]

Description

These changes bumps the github action upload-artifact and download-artifact to v4 based on these docs - https://github.com/actions/upload-artifact?tab=readme-ov-file#v4---whats-new. Migration info can be found here as well. https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md. Aside from bumping the version, the main breaking change is ensuring unique names, which in our case, only applies to the unit test shards (names are already unique)

Related issues

Fixes:

Manual testing steps

Check that unit test actions in Github CI works

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud