Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: STAKE-914 Remove MM_POOLED_STAKING_UI_ENABLED feature flag #12852

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: STAKE-914 Remove MM_POOLED_STAKING_UI_ENABLED feature flag #12852

wants to merge 1 commit into from

Conversation

Matt561
Copy link
Contributor

@Matt561 Matt561 commented Jan 7, 2025 •
edited
Loading

Description

This PR removes the MM_POOLED_STAKING_UI_ENABLED feature flag, removed related usages in the codebase, and updates breaking tests. We no longer need this feature flag as pooled-staking is live.

Related issues

Manual testing steps

N/A

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Matt561 Matt561 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed team-identity labels Jan 7, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 811f258
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/46d68023-eadd-4919-b4f3-156ee7625753

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Matt561 Matt561 force-pushed the feat/remove-pooled-staking-feature-flag branch 4 times, most recently from 2fb430f to 5ddf025 Compare January 8, 2025 18:07
@Matt561 Matt561 force-pushed the feat/remove-pooled-staking-feature-flag branch from 5ddf025 to 6fa36d8 Compare January 8, 2025 18:13
@Matt561 Matt561 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6fa36d8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/098e3ea8-f1e1-4bbe-a971-23a6dd7ccf7a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Matt561 Matt561 marked this pull request as ready for review January 8, 2025 21:32
@Matt561 Matt561 requested review from a team as code owners January 8, 2025 21:32
@Matt561 Matt561 requested a review from amitabh94 January 8, 2025 21:55
amitabh94
amitabh94 approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@amitabh94 amitabh94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tommasini
tommasini approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Pooled staking alive <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommasini tommasini tommasini approved these changes

@amitabh94 amitabh94 amitabh94 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-stake
Projects
PR review queue
Status: Needs dev review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Matt561 @amitabh94 @tommasini @metamaskbot