Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: assign CODEOWNERS to BrowserTab #12823

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

sethkfman
Copy link
Contributor

Description

The BrowserTab is a piece of critical functionality and it should only be update in certain scenarios. This PR add the maintainers of the browser to the BrowserTab

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

The BrowserTab is a piece of critical functionality and it should only be update in certain scenarios. This PR add the maintainers of the browser to the BrowserTab
@sethkfman sethkfman added No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform labels Dec 20, 2024
@sethkfman sethkfman requested a review from a team as a code owner December 20, 2024 22:15
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L added this pull request to the merge queue Jan 6, 2025
Merged via the queue into main with commit 3bb796f Jan 6, 2025
45 of 46 checks passed
@Cal-L Cal-L deleted the chore/codeowner-browser-tab branch January 6, 2025 22:02
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2025
@metamaskbot metamaskbot added the release-7.40.0 Issue or pull request that will be included in release 7.40.0 label Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.40.0 Issue or pull request that will be included in release 7.40.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants