Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: E2E to reveal SRP on error boundary screen #12805

Merged
merged 2 commits into from
Dec 20, 2024
Merged

test: E2E to reveal SRP on error boundary screen #12805

merged 2 commits into from
Dec 20, 2024
+137 −4

Conversation

cortisiko
Copy link
Member

@cortisiko cortisiko commented Dec 19, 2024 •
edited
Loading

Description

To catch any regressions in the crash screen’s reveal SRP flow, we should add an end-to-end (e2e) test. Since revealing the Secret Recovery Phrase is the user’s last chance to view and securely save it, this test will check that each step in the flow works smoothly: from entering your password to viewing your SRP.

Scenario: A user can reveal their SRP while on the crash screen
Given I encounter the crash screen
When I tap linked text to reveal my SRP
And I enter an invalid password
Then I should see the appropriate error
When I enter the correct password
Then I can see my SRP

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cortisiko cortisiko added the Run Smoke E2E Triggers smoke e2e on Bitrise label Dec 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: acc885f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4800a0ba-4c9f-4ffa-91e5-cbbaf31ebfd5

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cortisiko cortisiko self-assigned this Dec 19, 2024
@cortisiko cortisiko marked this pull request as ready for review December 19, 2024 23:15
@cortisiko cortisiko requested a review from a team as a code owner December 19, 2024 23:15
chrisleewilcox
chrisleewilcox previously approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortisiko cortisiko requested a review from a team as a code owner December 20, 2024 15:28
@cortisiko cortisiko added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 20, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 619d3a2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1cb632ea-e7b2-4a95-98bc-bae753c18e69

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

EtherWizard33
EtherWizard33 approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@EtherWizard33 EtherWizard33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortisiko cortisiko enabled auto-merge December 20, 2024 16:05
chrisleewilcox
chrisleewilcox approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortisiko cortisiko added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit 9e11cf6 Dec 20, 2024
40 checks passed
@cortisiko cortisiko deleted the 2027-e2e-create-test-to-reveal-srp-on-crash-screen branch December 20, 2024 16:20
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EtherWizard33 EtherWizard33 EtherWizard33 approved these changes

@chrisleewilcox chrisleewilcox chrisleewilcox approved these changes

Assignees

@cortisiko cortisiko

Labels
release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cortisiko @chrisleewilcox @EtherWizard33 @metamaskbot