refactor: rename multichain e2e pipeline and add multichain assets pipeline #12785

EtherWizard33 · 2024-12-19T09:38:02Z

Description

This PR renames the multichain e2e pipeline to be more specific about permissions and adds a new pipeline for multichain assets testing.

Changes were made in a hierarchical order:

Renamed existing pipeline for clarity:
- multichain_e2e_pipeline → multichain_permissions_e2e_pipeline
- Renamed stages to include "permissions":
  - build_multichain_e2e_ios_android_stage → build_multichain_permissions_e2e_ios_android_stage
  - run_multichain_e2e_ios_android_stage → run_multichain_permissions_e2e_ios_android_stage
- Renamed build workflows:
  - build_ios_multichain_e2e → build_ios_multichain_permissions_e2e
  - build_android_multichain_e2e → build_android_multichain_permissions_e2e
- Renamed test workflows:
  - run_tag_multichain_ios → run_tag_multichain_permissions_ios
  - run_tag_multichain_android → run_tag_multichain_permissions_android
Added new pipeline for multichain assets:
- Created multichain_assets_e2e_pipeline with corresponding stages and workflows
- Added new test tag SmokeMultiChainAssets
- Integrated assets test workflows into existing smoke test suite

These changes improve naming consistency throughout the CI pipeline while adding new functionality for multichain assets testing.

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…permissions

…ermissions

github-actions · 2024-12-19T09:38:15Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions · 2024-12-19T09:38:31Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5304f3e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b3e537fd-0c19-43cf-97dd-f8d098251c4e

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

EtherWizard33 · 2024-12-19T09:38:37Z

bitrise.yml

@@ -71,10 +71,10 @@ pipelines:
    stages:
      - create_build_qa_android: {}
      - app_upgrade_test_stage: {}
-  multichain_e2e_pipeline:
+  multichain_permissions_e2e_pipeline:


renamed the pipeline to be more specific by including permissions in its name

EtherWizard33 · 2024-12-19T09:40:13Z

bitrise.yml

@@ -140,15 +140,15 @@ stages:
    workflows:
      - ios_e2e_build: {}
      - android_e2e_build: {}
-  build_multichain_e2e_ios_android_stage:
+  build_multichain_permissions_e2e_ios_android_stage:


renamed the stages to be more specific by including permissions in their names

EtherWizard33 · 2024-12-19T09:41:45Z

bitrise.yml

@@ -683,13 +683,13 @@ workflows:
      - TEST_SUITE_TAG: '.*SmokeCore.*'
    after_run:
      - android_e2e_test
-  run_tag_multichain_ios:
+  run_tag_multichain_permissions_ios:


renamed the multichain workflows to include permissions in their name

…missions

…droid_stage

EtherWizard33 · 2024-12-19T13:47:25Z

bitrise.yml

-      - run_multichain_e2e_ios_android_stage: {}
+      - build_multichain_permissions_e2e_ios_android_stage: {}
+      - run_multichain_permissions_e2e_ios_android_stage: {}
+  multichain_assets_e2e_pipeline:


added the new mulithchain assets e2e pipeline

EtherWizard33 · 2024-12-19T13:48:17Z

bitrise.yml

+    workflows:
+      - run_tag_multichain_permissions_ios: {}
+      - run_tag_multichain_permissions_android: {}
+  build_multichain_assets_e2e_ios_android_stage:


added the new mulithchain assets e2e build stage

EtherWizard33 · 2024-12-19T13:48:47Z

bitrise.yml

-  run_multichain_e2e_ios_android_stage:
+      - build_ios_multichain_assets_e2e: {}
+      - build_android_multichain_assets_e2e: {}
+  run_multichain_assets_e2e_ios_android_stage:


added the new mulithchain assets e2e run stage

EtherWizard33 · 2024-12-19T13:49:42Z

bitrise.yml

+      - TEST_SUITE_TAG: '.*SmokeMultiChainPermissions.*'
+    after_run:
+      - ios_e2e_test
+  run_tag_multichain_permissions_android:


added the new mulithchain assets e2e workflows

sonarqubecloud · 2024-12-19T13:54:03Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2024-12-19T13:58:33Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: de7434f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ffad37c0-a490-4c3b-9a1c-5bd8d70fd5a6

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

EtherWizard33 · 2024-12-20T10:56:12Z

closing in favor of another PR which does not add the new workflow but does rename the existing multichain workflow to multichain permissions: #12809

EtherWizard33 added 4 commits December 19, 2024 12:01

refactor: rename the multichain pipeline

7ced3ba

refactor(stages): rename multichain stages to multichain permissions

56935f1

refactor(workflows): rename multichain build workflows to multichain …

be20c2b

…permissions

refactor(workflows): rename multichain test workflows to multichain p…

5304f3e

…ermissions

EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux labels Dec 19, 2024

EtherWizard33 commented Dec 19, 2024

View reviewed changes

EtherWizard33 added 5 commits December 19, 2024 12:53

refactor(workflows): update multichain test tag to SmokeMultiChainPer…

a147cc4

…missions

feat(workflows): add multichain assets build and test workflows

27f49c2

feat(stages): add multichain assets build and test stages

ba69584

feat(pipeline): add multichain assets e2e pipeline

931d756

feat(stages): add multichain assets workflows to run_smoke_e2e_ios_an…

7824192

…droid_stage

EtherWizard33 changed the title ~~refactor: rename multichain e2e pipeline to multichain permissions~~ refactor: rename multichain e2e pipeline to multichain permissions and create a new pipeline to contain existing multichain assets e2e tests Dec 19, 2024

EtherWizard33 changed the title ~~refactor: rename multichain e2e pipeline to multichain permissions and create a new e2e pipeline to contain existing multichain assets tests~~ refactor: rename multichain e2e pipeline to multichain permissions Dec 19, 2024

EtherWizard33 added 3 commits December 19, 2024 13:31

feat(tags): add SmokeMultiChainAssets tag for multichain assets tests

93f741e

fix: remove duplicate stage section

b96c412

fix: remove duplicate workflows tag

de7434f

EtherWizard33 changed the title ~~refactor: rename multichain e2e pipeline to multichain permissions~~ refactor: rename multichain e2e pipeline and add multichain assets pipeline Dec 19, 2024

EtherWizard33 commented Dec 19, 2024

View reviewed changes

EtherWizard33 marked this pull request as ready for review December 19, 2024 13:49

EtherWizard33 requested review from a team as code owners December 19, 2024 13:49

EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 19, 2024

EtherWizard33 mentioned this pull request Dec 19, 2024

chore: assets mc ci final #12792

Closed

7 tasks

EtherWizard33 closed this Dec 20, 2024

github-actions bot locked and limited conversation to collaborators Dec 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: rename multichain e2e pipeline and add multichain assets pipeline #12785

refactor: rename multichain e2e pipeline and add multichain assets pipeline #12785

EtherWizard33 commented Dec 19, 2024 •

edited

Loading

github-actions bot commented Dec 19, 2024

github-actions bot commented Dec 19, 2024 •

edited by metamaskbot

Loading

EtherWizard33 Dec 19, 2024 •

edited

Loading

EtherWizard33 Dec 19, 2024 •

edited

Loading

EtherWizard33 Dec 19, 2024

EtherWizard33 Dec 19, 2024

EtherWizard33 Dec 19, 2024

EtherWizard33 Dec 19, 2024

EtherWizard33 Dec 19, 2024

sonarqubecloud bot commented Dec 19, 2024

github-actions bot commented Dec 19, 2024 •

edited by metamaskbot

Loading

EtherWizard33 commented Dec 20, 2024

refactor: rename multichain e2e pipeline and add multichain assets pipeline #12785

refactor: rename multichain e2e pipeline and add multichain assets pipeline #12785

Conversation

EtherWizard33 commented Dec 19, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Dec 19, 2024

github-actions bot commented Dec 19, 2024 • edited by metamaskbot Loading

Bitrise

EtherWizard33 Dec 19, 2024 • edited Loading

Choose a reason for hiding this comment

EtherWizard33 Dec 19, 2024 • edited Loading

Choose a reason for hiding this comment

EtherWizard33 Dec 19, 2024

Choose a reason for hiding this comment

EtherWizard33 Dec 19, 2024

Choose a reason for hiding this comment

EtherWizard33 Dec 19, 2024

Choose a reason for hiding this comment

EtherWizard33 Dec 19, 2024

Choose a reason for hiding this comment

EtherWizard33 Dec 19, 2024

Choose a reason for hiding this comment

sonarqubecloud bot commented Dec 19, 2024

Quality Gate passed

github-actions bot commented Dec 19, 2024 • edited by metamaskbot Loading

Bitrise

EtherWizard33 commented Dec 20, 2024

EtherWizard33 commented Dec 19, 2024 •

edited

Loading

github-actions bot commented Dec 19, 2024 •

edited by metamaskbot

Loading

EtherWizard33 Dec 19, 2024 •

edited

Loading

EtherWizard33 Dec 19, 2024 •

edited

Loading

github-actions bot commented Dec 19, 2024 •

edited by metamaskbot

Loading