Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Design Quality] Updated navbar title to remove green dot #12773

Merged
merged 6 commits into from
Dec 20, 2024

Conversation

brianacnguyen
Copy link
Contributor

@brianacnguyen brianacnguyen commented Dec 18, 2024

Description

  • This PR updates the navbar title to remove the green dot
  • Also updated the navbar title in Receive flow

Related issues

Fixes: #12768

Manual testing steps

  1. Go to wallet
  2. Click on asset
  3. Observe change in header
  4. Go to receive
  5. Observe change in header

Screenshots/Recordings

Before

After

https://github.com/user-attachments/assets/84d7e1c0-a9a9-4c26-9584-6d83cd1614bd
Screenshot_1734556451
Screenshot_1734557087

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen requested a review from a team as a code owner December 18, 2024 20:52
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@brianacnguyen brianacnguyen self-assigned this Dec 18, 2024
@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-design-system All issues relating to design system in Mobile labels Dec 18, 2024
@brianacnguyen brianacnguyen added the Run Smoke E2E Triggers smoke e2e on Bitrise label Dec 18, 2024
Copy link
Contributor

github-actions bot commented Dec 18, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4637a3d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/07e4ab18-89bf-472c-98fd-2c627ec2ac91

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@brianacnguyen brianacnguyen added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 18, 2024
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: c493690
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1925d050-1cb4-4570-81c2-987430b23893

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@brianacnguyen brianacnguyen requested review from a team as code owners December 18, 2024 22:29
@brianacnguyen brianacnguyen added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 18, 2024
Copy link
Contributor

github-actions bot commented Dec 18, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 81735b3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/37627cfa-2fff-45f7-8079-15ab1884fbf8

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@brianacnguyen brianacnguyen added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 18, 2024
Copy link
Member

@wachunei wachunei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ramp Snapshot changes LGTM

@brianacnguyen brianacnguyen added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit 754f4f9 Dec 20, 2024
44 checks passed
@brianacnguyen brianacnguyen deleted the header/navbartitle branch December 20, 2024 19:05
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Dec 20, 2024
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-design-system All issues relating to design system in Mobile
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Design quality]: Update the mobile header to the design system header - Navbar Title & Receive Flow
8 participants