Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement send max to send flow #12754

Merged
merged 15 commits into from
Jan 9, 2025
Merged

feat: Implement send max to send flow #12754

merged 15 commits into from
Jan 9, 2025
+226 −40

Conversation

OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented Dec 18, 2024 •
edited
Loading

Description

This PR implements "Use Max" feature to the send flow.

In the Amount step we set maxValueMode as true. When user gets in to the Confirm step, depending on the value, transaction value is getting updated.

Related issues

#8516

Manual testing steps

  1. Try send eth - initiate from wallet
  2. "Use max" value on the Amount screen
  3. See that amount is adjusted on every gas update

Screenshots/Recordings

send.flow.max.eth.mp4

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz linked an issue Dec 18, 2024 that may be closed by this pull request
[Bug]: When sending 'max' amount ETH value is not adjusted in response to changes in the gas fee. #8516
Closed
@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Dec 18, 2024
@OGPoyraz OGPoyraz changed the title fix: Fix send max eth feature feat: Implement send max to send flow Dec 18, 2024
@OGPoyraz OGPoyraz added Run Smoke E2E Triggers smoke e2e on Bitrise No QA Needed Apply this label when your PR does not need any QA effort. labels Dec 18, 2024
@MetaMask MetaMask deleted a comment from github-actions bot Dec 18, 2024
@OGPoyraz OGPoyraz added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 39d4b19
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f359a44f-8410-444e-a52c-33313a225d90

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@OGPoyraz OGPoyraz added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 18, 2024
@OGPoyraz OGPoyraz marked this pull request as ready for review December 18, 2024 14:06
@OGPoyraz OGPoyraz requested review from a team as code owners December 18, 2024 14:06
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: f33da7b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/540f6c09-a304-4fad-bd5d-05821ba0b536

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

jpuri
jpuri previously approved these changes Dec 20, 2024
View reviewed changes
@OGPoyraz
Merge branch 'main' into 8516-bug-when-sending-max-amount-eth-value-i…
7478846 
…s-not-adjusted-in-response-to-changes-in-the-gas-fee
@OGPoyraz OGPoyraz added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 6, 2025
@OGPoyraz OGPoyraz enabled auto-merge January 6, 2025 08:00
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7478846
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5f9d2279-5459-42c7-8999-34610963b4d7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@OGPoyraz OGPoyraz added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 6, 2025
jpuri
jpuri previously approved these changes Jan 7, 2025
View reviewed changes
@OGPoyraz
Merge branch 'main' into 8516-bug-when-sending-max-amount-eth-value-i…
544b438 
…s-not-adjusted-in-response-to-changes-in-the-gas-fee
@OGPoyraz OGPoyraz added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 8, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
69.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@OGPoyraz OGPoyraz added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 544b438
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/140ed73c-9070-4032-a922-2d4f01075906

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@OGPoyraz OGPoyraz added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 9, 2025
@OGPoyraz OGPoyraz added this pull request to the merge queue Jan 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 9, 2025
@OGPoyraz OGPoyraz added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit 2c5a2d0 Jan 9, 2025
48 of 49 checks passed
@OGPoyraz OGPoyraz deleted the 8516-bug-when-sending-max-amount-eth-value-is-not-adjusted-in-response-to-changes-in-the-gas-fee branch January 9, 2025 12:32
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2025
@metamaskbot metamaskbot added the release-7.40.0 Issue or pull request that will be included in release 7.40.0 label Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpuri jpuri jpuri approved these changes

Assignees
No one assigned
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.40.0 Issue or pull request that will be included in release 7.40.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: When sending 'max' amount ETH value is not adjusted in response to changes in the gas fee.
3 participants
@OGPoyraz @jpuri @metamaskbot