Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide ApprovalTagUrl when origins is internal #12629

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

vinistevam
Copy link
Contributor

@vinistevam vinistevam commented Dec 10, 2024

Description

This PR aims to omit the origin pill when the origin is internal.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3777

Manual testing steps

  1. On your wallet view, click on "Earn"
  2. Go through the staking flow
  3. See no origin pill on the confirmation

Screenshots/Recordings

stake.mp4

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinistevam vinistevam added the team-confirmations Push issues to confirmations team label Dec 10, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinistevam vinistevam added the Run Smoke E2E Triggers smoke e2e on Bitrise label Dec 10, 2024
Copy link
Contributor

github-actions bot commented Dec 10, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9f854c6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c741801e-4742-44d5-b47a-cefedc0deff9

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@vinistevam vinistevam force-pushed the fix/hide-stake-origin branch from 9f854c6 to 166d689 Compare December 10, 2024 22:20
@vinistevam vinistevam marked this pull request as ready for review December 10, 2024 22:28
@vinistevam vinistevam requested a review from a team as a code owner December 10, 2024 22:28
@vinistevam vinistevam added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 11, 2024
Copy link
Contributor

github-actions bot commented Dec 11, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 35dd055
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/01dbbcde-6160-4e22-8a73-72703c288a17

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinistevam vinistevam added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 6, 2025
Copy link
Contributor

github-actions bot commented Jan 6, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: edef42a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3adbf421-a71a-41b4-b07a-d88dc5f26f64

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinistevam vinistevam added this pull request to the merge queue Jan 6, 2025
Merged via the queue into main with commit d0942f5 Jan 6, 2025
41 checks passed
@vinistevam vinistevam deleted the fix/hide-stake-origin branch January 6, 2025 13:37
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2025
@metamaskbot metamaskbot added the release-7.40.0 Issue or pull request that will be included in release 7.40.0 label Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.40.0 Issue or pull request that will be included in release 7.40.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants