Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin react-native-tcp to hash #12595

Merged
merged 1 commit into from
Dec 17, 2024
Merged

chore: pin react-native-tcp to hash #12595

merged 1 commit into from
Dec 17, 2024

Conversation

leotm
Copy link
Member

@leotm leotm commented Dec 6, 2024

Description

Fix it to the git commit hash we're using (yarn.lock resolved url tar.gz hash),
instead of the latest commit on a contributor's pr branch on the fork (package.json)

i.e. aprock/react-native-tcp@98fbc80
(note: master is few commits ahead)

note: our develop has two more such cases (1, 2)

Related issues

Fixes: variable commit hashes, if the lockfile were to be removed/regenerated

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@leotm leotm requested review from a team as code owners December 6, 2024 16:04
@leotm leotm added No QA Needed Apply this label when your PR does not need any QA effort. No E2E Smoke Needed If the PR does not need E2E smoke test run labels Dec 6, 2024
@leotm leotm force-pushed the chore/pin-react-native-tcp branch from 4193d9d to da0c8e1 Compare December 6, 2024 16:14
@naugtur
Copy link

naugtur commented Dec 6, 2024

Please pin all in one go unless we have good reasons not to

@leotm
Copy link
Member Author

leotm commented Dec 16, 2024

Please pin all in one go unless we have good reasons not to

yep this is all #X/head deps on master pinned

(develop is stale last updated ~3y ago, we could do that too in a separate PR if deemed neccessary)

Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we run the e2e?
LGTM!

@leotm leotm added this pull request to the merge queue Dec 16, 2024
@leotm
Copy link
Member Author

leotm commented Dec 16, 2024

Can we run the e2e? LGTM!

thank you ^ just noting added the No E2E Smoke Needed label since the yarn.lock resolved url tar.gz hash remains the same (i.e. it's the same dependency)

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 16, 2024
@leotm leotm added this pull request to the merge queue Dec 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 17, 2024
@leotm
Copy link
Member Author

leotm commented Dec 17, 2024

github-merge-queue bot removed this pull request from the merge queue] due to no response for status checks (no failed tests) hmm

now audit:ci failing ✘ Audit shows 7 moderate or high severity advisories in the production dependencies on bunch of PRs 🤔
edit: nice work @tommasini getting on it MetaMask/core#5073 #12725

@leotm leotm force-pushed the chore/pin-react-native-tcp branch from da0c8e1 to 9929c33 Compare December 17, 2024 17:19
@leotm leotm enabled auto-merge December 17, 2024 17:20
@leotm leotm added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit 56ff643 Dec 17, 2024
36 checks passed
@leotm leotm deleted the chore/pin-react-native-tcp branch December 17, 2024 17:50
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2024
@metamaskbot metamaskbot added the release-99.100.99 Issue or pull request that will be included in release 99.100.99 label Dec 17, 2024
@cortisiko cortisiko added release-7.39.0 Issue or pull request that will be included in release 7.39.0 and removed release-99.100.99 Issue or pull request that will be included in release 99.100.99 labels Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. release-7.39.0 Issue or pull request that will be included in release 7.39.0 team-lavamoat team-mobile-platform team-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants