-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: pin react-native-tcp to hash #12595
Conversation
4193d9d
to
da0c8e1
Compare
Please pin all in one go unless we have good reasons not to |
yep this is all ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we run the e2e?
LGTM!
thank you ^ just noting added the |
now |
da0c8e1
to
9929c33
Compare
Quality Gate passedIssues Measures |
Description
Fix it to the git commit hash we're using (yarn.lock resolved url tar.gz hash),
instead of the latest commit on a contributor's pr branch on the fork (package.json)
i.e. aprock/react-native-tcp@98fbc80
(note:
master
is few commits ahead)note: our
develop
has two more such cases (1, 2)Related issues
Fixes: variable commit hashes, if the lockfile were to be removed/regenerated
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist