Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 10812 prevent redundant sentry sourcemap uploads #11844

Draft
wants to merge 42 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
843e6c2
made changes to bitrise.yml to stop the creating of Sentry sourcemaps
Daniel-Cross Sep 6, 2024
15b23f8
Merge branch 'main' into 10812-prevent-redundant-sentry-sourcemap-upl…
Daniel-Cross Sep 9, 2024
ffff32d
Merge branch 'main' into 10812-prevent-redundant-sentry-sourcemap-upl…
Daniel-Cross Sep 9, 2024
a545641
stopped Sentry Source Map creation as default and removed the skip en…
Daniel-Cross Sep 9, 2024
6b3dcab
Merge branch 'main' into 10812-prevent-redundant-sentry-sourcemap-upl…
Daniel-Cross Sep 10, 2024
e61ea99
Update scripts/build.sh
Daniel-Cross Sep 10, 2024
382a328
Merge branch 'main' into 10812-prevent-redundant-sentry-sourcemap-upl…
Daniel-Cross Sep 10, 2024
7313a80
Merge branch 'main' into 10812-prevent-redundant-sentry-sourcemap-upl…
Daniel-Cross Sep 10, 2024
dce5e2b
Merge branch 'main' into 10812-prevent-redundant-sentry-sourcemap-upl…
Daniel-Cross Sep 18, 2024
1704d94
disabled auto sourcemap upload for Android
Daniel-Cross Sep 18, 2024
87eaaa4
changed text from enable to disable
Daniel-Cross Sep 18, 2024
f90b6ce
changed build number to 1234 for testing
Daniel-Cross Sep 18, 2024
d074bdd
Merge branch 'main' into 10812-prevent-redundant-sentry-sourcemap-upl…
Daniel-Cross Sep 19, 2024
84f9c10
changed env variable for the release flow
Daniel-Cross Sep 19, 2024
b367d9e
added a condition to check for SENTRY_DISABLE_AUTO_UPLOAD
Daniel-Cross Sep 19, 2024
bd719f0
merged main
Daniel-Cross Sep 19, 2024
8b259a0
updated bitrise.yml after meeting with Seth to discuss how to run fro…
Daniel-Cross Sep 19, 2024
9ede8c5
kept all current changes from main conflicts for testing purposes
Daniel-Cross Sep 20, 2024
b99b974
Merge branch 'main' into 10812-prevent-redundant-sentry-sourcemap-upl…
Daniel-Cross Sep 20, 2024
35b32eb
Merge branch 'main' into 10812-prevent-redundant-sentry-sourcemap-upl…
Daniel-Cross Sep 23, 2024
693c6d2
moved from stages to workflows
Daniel-Cross Sep 23, 2024
6238cee
updated format
metamaskbot Sep 23, 2024
b0a1d08
remove setting sourcemaps env
metamaskbot Sep 23, 2024
bb20b53
Merge branch 'main' into 10812-prevent-redundant-sentry-sourcemap-upl…
sethkfman Sep 24, 2024
62e42e0
Merge branch 'main' into 10812-prevent-redundant-sentry-sourcemap-upl…
Daniel-Cross Sep 24, 2024
47d1330
update iOS build process
metamaskbot Sep 24, 2024
4a454b0
remove if check variables
metamaskbot Sep 24, 2024
c769d3c
Merge branch 'main' into 10812-prevent-redundant-sentry-sourcemap-upl…
Daniel-Cross Sep 25, 2024
5f060e9
changed versioncode¨
Daniel-Cross Sep 25, 2024
2782ccd
version name match
Daniel-Cross Sep 25, 2024
7ed877f
cleaned up PR
Daniel-Cross Sep 25, 2024
5dd604b
Merge branch 'main' into 10812-prevent-redundant-sentry-sourcemap-upl…
Daniel-Cross Sep 25, 2024
136dcb6
copied project file from main
Daniel-Cross Sep 25, 2024
65181c7
added space at bottom
Daniel-Cross Sep 25, 2024
4a17aa7
Merge branch 'main' into 10812-prevent-redundant-sentry-sourcemap-upl…
Daniel-Cross Sep 25, 2024
242fe97
Merge branch 'main' into 10812-prevent-redundant-sentry-sourcemap-upl…
Daniel-Cross Sep 25, 2024
59c2d3c
Merge branch 'main' into 10812-prevent-redundant-sentry-sourcemap-upl…
Daniel-Cross Sep 26, 2024
706fd41
Merge branch 'main' into 10812-prevent-redundant-sentry-sourcemap-upl…
Daniel-Cross Sep 26, 2024
ca8c230
Merge branch 'main' into 10812-prevent-redundant-sentry-sourcemap-upl…
sethkfman Sep 26, 2024
d041c38
revert upgrage change
metamaskbot Sep 26, 2024
6a846a6
add node -v back
metamaskbot Sep 26, 2024
423e319
Merge branch 'main' into 10812-prevent-redundant-sentry-sourcemap-upl…
Daniel-Cross Sep 27, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions bitrise.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ pipelines:
build_all_targets_pipeline:
stages:
- create_build_all_targets: {}
#Releases MetaMask apps and stores apk/ipa into Play(Internal Testing)/App(TestFlight) Store
release_builds_to_store_pipeline:
#Builds MetaMask apps and stores apk/ipa into Play(Internal Testing)/App(TestFlight) Store. Not for production release.
release_builds_to_test_flight:
stages:
- create_build_release: {}
- deploy_build_release: {}
- create_build_for_test_flight: {}
- deploy_build_for_test_flight: {}
- create_build_qa: {} #Generate QA builds for E2E app upgrade tests
#Releases MetaMask apps and stores ipa into App(TestFlight) Store
release_ios_to_store_pipeline:
Expand Down Expand Up @@ -89,11 +89,11 @@ stages:
- build_ios_release: {}
- build_android_qa: {}
- build_ios_qa: {}
create_build_release:
create_build_for_test_flight:
workflows:
- build_android_release: {}
- build_ios_release: {}
deploy_build_release:
deploy_build_for_test_flight:
workflows:
- deploy_android_to_store: {}
- deploy_ios_to_store: {}
Expand Down Expand Up @@ -997,6 +997,16 @@ workflows:
inputs:
- abort_on_fail: 'yes'
- access_token: $BITRISE_START_BUILD_ACCESS_TOKEN
build_ios_release_with_sourcemaps:
envs:
- SENTRY_DISABLE_AUTO_UPLOAD: false
after_run:
- build_ios_release
build_android_release_with_sourcemaps:
envs:
- SENTRY_DISABLE_AUTO_UPLOAD: false
after_run:
- build_android_release
build_android_release:
before_run:
- code_setup
Expand Down Expand Up @@ -1060,7 +1070,7 @@ workflows:
inputs:
- pipeline_intermediate_files: sourcemaps/android/index.js.map:BITRISE_PLAY_STORE_SOURCEMAP_PATH
- deploy_path: sourcemaps/android/index.js.map
title: Bitrise Deploy Sourcemaps
title: Deploy Source Map
meta:
bitrise.io:
stack: linux-docker-android-22.04
Expand Down
5 changes: 0 additions & 5 deletions scripts/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -299,9 +299,6 @@ generateArchivePackages() {
buildIosRelease(){
remapEnvVariableRelease

# Enable Sentry to auto upload source maps and debug symbols
export SENTRY_DISABLE_AUTO_UPLOAD="false"

prebuild_ios

# Replace release.xcconfig with ENV vars
Expand Down Expand Up @@ -422,8 +419,6 @@ buildAndroidRelease(){
adb uninstall io.metamask || true
fi

# Enable Sentry to auto upload source maps and debug symbols
export SENTRY_DISABLE_AUTO_UPLOAD="false"
prebuild_android

# GENERATE APK
Expand Down
Loading