Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactor notifications unit tests #11431

Merged
merged 41 commits into from
Oct 14, 2024
Merged

fix: refactor notifications unit tests #11431

merged 41 commits into from
Oct 14, 2024

Conversation

Jonathansoufer
Copy link
Contributor

@Jonathansoufer Jonathansoufer commented Sep 25, 2024 •
edited by NicolasMassart
Loading

Description

This PR addresses all comments from this PR related to unit tests best practices.

Related issues

Fixes: #11250

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Jonathansoufer Jonathansoufer added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform No E2E Smoke Needed If the PR does not need E2E smoke test run team-notifications Notifications team labels Sep 25, 2024
@Jonathansoufer Jonathansoufer self-assigned this Sep 25, 2024
@Jonathansoufer Jonathansoufer requested review from a team as code owners September 25, 2024 10:42
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-snaps-platform Snaps Platform team label Sep 25, 2024
NicolasMassart
NicolasMassart reviewed Sep 25, 2024
View reviewed changes
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work moving the toggle in a hook!
I have questions about the channel ids and android test.
Some comments also about naming mostly to make the tests clear as doc.

app/util/notifications/hooks/index.test.ts Outdated Show resolved Hide resolved
app/util/notifications/hooks/index.test.ts Outdated Show resolved Hide resolved
app/util/notifications/hooks/index.test.ts Outdated Show resolved Hide resolved
app/util/notifications/hooks/index.test.ts Outdated Show resolved Hide resolved
app/util/notifications/androidChannels.test.ts Outdated Show resolved Hide resolved
app/components/Views/Settings/NotificationsSettings/index.test.tsx Outdated Show resolved Hide resolved
app/components/Views/Settings/NotificationsSettings/index.test.tsx Outdated Show resolved Hide resolved
app/components/Views/Settings/NotificationsSettings/index.test.tsx Outdated Show resolved Hide resolved
app/components/Views/Settings/NotificationsSettings/useToggleNotifications.test.tsx Outdated Show resolved Hide resolved
app/components/Views/Settings/NotificationsSettings/useToggleNotifications.test.tsx Outdated Show resolved Hide resolved
Jonathansoufer and others added 9 commits September 25, 2024 17:43
@Jonathansoufer @NicolasMassart
Update app/util/notifications/hooks/index.test.ts
438d5c4 
Co-authored-by: Nico MASSART <[email protected]>
@Jonathansoufer @NicolasMassart
Update app/util/notifications/androidChannels.test.ts
92877e7 
Co-authored-by: Nico MASSART <[email protected]>
@Jonathansoufer @NicolasMassart
Update app/components/Views/Settings/NotificationsSettings/index.test…
f82813b 
….tsx

Co-authored-by: Nico MASSART <[email protected]>
@Jonathansoufer @NicolasMassart
Update app/components/Views/Settings/NotificationsSettings/useToggleN…
84e65eb 
…otifications.test.tsx

Co-authored-by: Nico MASSART <[email protected]>
@Jonathansoufer @NicolasMassart
Update app/components/Views/Settings/NotificationsSettings/useToggleN…
301255e 
…otifications.test.tsx

Co-authored-by: Nico MASSART <[email protected]>
@Jonathansoufer @NicolasMassart
Update app/util/notifications/androidChannels.test.ts
d4c03b1 
Co-authored-by: Nico MASSART <[email protected]>
@Jonathansoufer @NicolasMassart
Update app/util/notifications/androidChannels.test.ts
629a56d 
Co-authored-by: Nico MASSART <[email protected]>
@Jonathansoufer @NicolasMassart
Update app/util/notifications/androidChannels.test.ts
850a6d7 
Co-authored-by: Nico MASSART <[email protected]>
polishes unit test
5225989
Merge branch 'fix/refactor-notifications-unit-tests' of github.com:Me…
58522a0 
…taMask/metamask-mobile into fix/refactor-notifications-unit-tests
@Jonathansoufer
Copy link
Contributor Author

Why completely delete app/util/notifications/hooks/index.test.ts?

mistakenly removed. Put it Back.

NicolasMassart
NicolasMassart reviewed Oct 8, 2024
View reviewed changes
app/util/notifications/hooks/index.test.ts Outdated Show resolved Hide resolved
app/util/notifications/hooks/index.test.ts Outdated Show resolved Hide resolved
app/util/notifications/hooks/index.test.ts Outdated Show resolved Hide resolved
app/util/notifications/hooks/index.test.ts Outdated Show resolved Hide resolved
app/util/notifications/hooks/index.test.ts Outdated Show resolved Hide resolved
app/util/notifications/hooks/index.test.ts Outdated Show resolved Hide resolved
app/util/notifications/hooks/index.test.ts Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

NicolasMassart
NicolasMassart approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

andreahaku
andreahaku reviewed Oct 14, 2024
View reviewed changes
Copy link
Contributor

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one very minor comment.
The rest is ok.

app/components/Views/Settings/NotificationsSettings/useToggleNotifications.ts Show resolved Hide resolved
andreahaku
andreahaku approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jonathansoufer Jonathansoufer added this pull request to the merge queue Oct 14, 2024
Merged via the queue into main with commit 7bc75e9 Oct 14, 2024
37 checks passed
@Jonathansoufer Jonathansoufer deleted the fix/refactor-notifications-unit-tests branch October 14, 2024 17:00
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

@andreahaku andreahaku andreahaku approved these changes

@NicolasMassart NicolasMassart NicolasMassart approved these changes

Assignees

@Jonathansoufer Jonathansoufer

Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. release-7.34.0 team-mobile-platform team-notifications Notifications team team-snaps-platform Snaps Platform team
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Jonathansoufer @NicolasMassart @andreahaku @Prithpal-Sooriya @gauthierpetetin