Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(js-ts): Convert app/util/jsonRpcRequest.js to TypeScript #11407

Merged

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Sep 24, 2024

Converted jsonRpcRequest.js to TypeScript. Link to Devin run: https://preview.devin.ai/devin/1d96b75a5ca94053b81023a1cc531aeb

If you have any feedback, you can leave comments in the PR and I'll address them in the app!

@devin-ai-integration devin-ai-integration bot requested a review from a team as a code owner September 24, 2024 06:31
@devin-ai-integration devin-ai-integration bot added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform labels Sep 24, 2024
@github-actions github-actions bot added the team-ai AI team (for the Devin AI bot) label Sep 24, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment

app/util/jsonRpcRequest.ts Outdated Show resolved Hide resolved
@Cal-L Cal-L enabled auto-merge September 24, 2024 17:35
@Cal-L Cal-L added this pull request to the merge queue Sep 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 25, 2024
@devin-ai-integration devin-ai-integration bot added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Sep 25, 2024
Copy link
Contributor Author

Triggering CI rerun

Copy link

@smilingkylan smilingkylan added this pull request to the merge queue Oct 3, 2024
Merged via the queue into main with commit 348c4cb Oct 3, 2024
36 checks passed
@smilingkylan smilingkylan deleted the convert-ts-jsonRpcRequest-{{random_number_3_digits}} branch October 3, 2024 18:27
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 3, 2024
@gauthierpetetin gauthierpetetin added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.33.0 Issue or pull request that will be included in release 7.33.0 skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-ai AI team (for the Devin AI bot) team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants