-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Prevent redundant Sentry sourcemap uploads #11081
chore: Prevent redundant Sentry sourcemap uploads #11081
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Co-authored-by: legobeat <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11081 +/- ##
==========================================
- Coverage 55.84% 53.76% -2.09%
==========================================
Files 1594 1632 +38
Lines 37855 38136 +281
Branches 4545 4618 +73
==========================================
- Hits 21142 20502 -640
- Misses 16214 16224 +10
- Partials 499 1410 +911
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Made a change to
bitrise.yml
that renames the flow for builds that are made specifically for testing purposes and not for production.The change adds an env variable that skips the creation of Sentry source map files if the env variable is found.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
NA
After
build_android_release_with_sourcemaps
build_android_release
build_ios_release_with_sourcemaps
build_ios_release
Pre-merge author checklist
Pre-merge reviewer checklist