Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Prevent redundant Sentry sourcemap uploads #11081

Merged
merged 42 commits into from
Sep 27, 2024

Conversation

Daniel-Cross
Copy link
Contributor

@Daniel-Cross Daniel-Cross commented Sep 6, 2024

Description

Made a change to bitrise.yml that renames the flow for builds that are made specifically for testing purposes and not for production.

The change adds an env variable that skips the creation of Sentry source map files if the env variable is found.

Related issues

Fixes:

Manual testing steps

  1. Trigger a build that doesn't say source maps -> see source map upload is skipped
  2. Trigger a build that does say source maps -> see source map upload is completed

Screenshots/Recordings

Before

NA

After

build_android_release_with_sourcemaps
Screenshot 2024-09-24 at 8 58 27 AM

build_android_release
Screenshot 2024-09-24 at 8 59 28 AM

build_ios_release_with_sourcemaps

build_ios_release
Screenshot 2024-09-24 at 9 02 04 AM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Daniel-Cross Daniel-Cross self-assigned this Sep 6, 2024
@Daniel-Cross Daniel-Cross linked an issue Sep 6, 2024 that may be closed by this pull request
9 tasks
Copy link
Contributor

github-actions bot commented Sep 6, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Daniel-Cross Daniel-Cross added team-mobile-delivery No QA Needed Apply this label when your PR does not need any QA effort. and removed team-mobile-platform labels Sep 6, 2024
@Daniel-Cross Daniel-Cross marked this pull request as ready for review September 9, 2024 07:40
@Daniel-Cross Daniel-Cross requested review from a team as code owners September 9, 2024 07:40
bitrise.yml Show resolved Hide resolved
@Daniel-Cross Daniel-Cross requested a review from a team as a code owner September 9, 2024 21:45
scripts/build.sh Outdated Show resolved Hide resolved
@legobeat legobeat requested review from sethkfman and a team September 10, 2024 09:22
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.76%. Comparing base (b9dbf4d) to head (d041c38).
Report is 44 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11081      +/-   ##
==========================================
- Coverage   55.84%   53.76%   -2.09%     
==========================================
  Files        1594     1632      +38     
  Lines       37855    38136     +281     
  Branches     4545     4618      +73     
==========================================
- Hits        21142    20502     -640     
- Misses      16214    16224      +10     
- Partials      499     1410     +911     
Flag Coverage Δ
53.76% <ø> (-2.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

scripts/build.sh Outdated Show resolved Hide resolved
bitrise.yml Show resolved Hide resolved
@sethkfman sethkfman enabled auto-merge September 26, 2024 22:49
Copy link

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit 65b6684 Sep 27, 2024
36 checks passed
@sethkfman sethkfman deleted the 10812-prevent-redundant-sentry-sourcemap-uploads branch September 27, 2024 15:01
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2024
@metamaskbot metamaskbot added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Sep 27, 2024
@sethkfman sethkfman restored the 10812-prevent-redundant-sentry-sourcemap-uploads branch October 17, 2024 16:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.33.0 Issue or pull request that will be included in release 7.33.0 team-mobile-delivery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent redundant Sentry sourcemap uploads
5 participants