Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add Wallet API Platform Team as CODEOWNER for the RPCMethods/ directory #10716

Merged
merged 4 commits into from
Jan 6, 2025
Merged

chore: Add Wallet API Platform Team as CODEOWNER for the RPCMethods/ directory #10716

merged 4 commits into from
Jan 6, 2025
+3 −0

Conversation

adonesky1
Copy link
Contributor

Description

Update RPCMethods directory CODEOWNER to the Wallet API Platform Team.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@adonesky1 adonesky1 force-pushed the ad/wallet-api-patform-codeowners branch from 2355798 to 4604bed Compare August 20, 2024 15:20
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@adonesky1 adonesky1 added the No QA Needed Apply this label when your PR does not need any QA effort. label Aug 20, 2024
@adonesky1 adonesky1 changed the title chore: Add Wallet API Platform Team as CODEOWNER for the RPCMethods/` directory chore: Add Wallet API Platform Team as CODEOWNER for the RPCMethods/ directory Aug 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issues that have not had activity in the last 90 days label Nov 19, 2024
sethkfman
sethkfman previously approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman
Copy link
Contributor

@adonesky1 This looks good to merge.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions github-actions bot removed the stale Issues that have not had activity in the last 90 days label Nov 22, 2024
@adonesky1 adonesky1 marked this pull request as ready for review January 6, 2025 21:38
@adonesky1 adonesky1 requested a review from a team as a code owner January 6, 2025 21:38
@adonesky1 adonesky1 added No QA Needed Apply this label when your PR does not need any QA effort. and removed No QA Needed Apply this label when your PR does not need any QA effort. labels Jan 6, 2025
@adonesky1 adonesky1 added No QA Needed Apply this label when your PR does not need any QA effort. and removed No QA Needed Apply this label when your PR does not need any QA effort. labels Jan 6, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@adonesky1 adonesky1 added the No E2E Smoke Needed If the PR does not need E2E smoke test run label Jan 6, 2025
@adonesky1 adonesky1 added this pull request to the merge queue Jan 6, 2025
Merged via the queue into main with commit 724ec84 Jan 6, 2025
43 checks passed
@adonesky1 adonesky1 deleted the ad/wallet-api-patform-codeowners branch January 6, 2025 22:22
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2025
@metamaskbot metamaskbot added the release-7.40.0 Issue or pull request that will be included in release 7.40.0 label Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. release-7.40.0 Issue or pull request that will be included in release 7.40.0 team-wallet-api-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adonesky1 @sethkfman @metamaskbot